[GitHub] [spark] huaxingao commented on a diff in pull request #40308: [SPARK-42151][SQL] Align UPDATE assignments with table attributes

["huaxingao (via GitHub)" <gi...@apache.org>]

huaxingao commented on code in PR #40308:
URL: https://github.com/apache/spark/pull/40308#discussion_r1131767473


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3344,43 +3345,6 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
         } else {
           v2Write
         }
-
-      case u: UpdateTable if !u.skipSchemaResolution && u.resolved =>

Review Comment:
   I don't have a strong opinion on runtime error or analysis error, but I agree that we need to unify the behaviors.
   
   If I remember correctly, DB2 has a Query Transformation and Semantics layer. The null check is done there instead of run time, but I don't know how this is done in other databases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org