[GitHub] erisu commented on a change in pull request #612: Android Platform Release Preparation (Cordova 9)

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #612: Android Platform Release Preparation (Cordova 9)
URL: https://github.com/apache/cordova-android/pull/612#discussion_r246614064
 
 

 ##########
 File path: package.json
 ##########
 @@ -48,7 +46,6 @@
     "eslint-plugin-promise": "^4.0.1",
     "eslint-plugin-standard": "^4.0.0",
     "jasmine": "^3.3.1",
-    "npm-run-all": "^4.1.5",
 
 Review comment:
   I didn't think it was necessary to keep for only one use case.
   
   There were two cases, but that second case was not actually needed. 
   
   IF we still had a pattern matching requirement and didn't require any order, maybe it would have been worth keeping. 
   
   In the end, I felt it became more of bloatware since there was only one use case left and all it was doing was shorting the line by 13 chars.
   
   ```
   run-s eslint unit-tests java-unit-tests e2e-tests
   ```
   and
   ```
   npm run eslint && npm run cover && npm run java-unit-tests
   ```
   
   The package itself is 156kb in size but with all its dependencies it was about 2.4mb. Even though some of the sub-dependencies we may already have from other packages.
   
   I felt it might be better to just cut/downsize.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org