You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <be...@systemoutprintln.de> on 2012/01/22 23:31:49 UTC
Re: [jira] [Resolved] (SANDBOX-363) Check if value is of the correct
type in Argument.argument( Class type, V value )
Am 22.01.2012 22:32, schrieb Simone Tripodi (Resolved) (JIRA):
>
> [ https://issues.apache.org/jira/browse/SANDBOX-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Simone Tripodi resolved SANDBOX-363.
> ------------------------------------
>
> Resolution: Fixed
> Assignee: Simone Tripodi
>
> patch applied, see [r1234616|https://svn.apache.org/viewvc?view=revision&revision=1234616]
>
> as a side note: {{Argument.getParameterTypes}} is an internal method, I moved the checks in the higher level, as soon as arguments need to be checked, because invoked in constructors or methods.
getParameterTypes has default visibility and for that reason can be used
by other classes (for example BeanAccessor ;-). So I wouldn't exactly
call it an internal method. Wouldn't it be better to leave the check in
there?
>
> Thanks for contributing! ;)
>
>> Check if value is of the correct type in Argument.argument( Class<T> type, V value )
>> ------------------------------------------------------------------------------------
>>
>> Key: SANDBOX-363
>> URL: https://issues.apache.org/jira/browse/SANDBOX-363
>> Project: Commons Sandbox
>> Issue Type: Improvement
>> Components: BeanUtils2
>> Affects Versions: Nightly Builds
>> Reporter: Benedikt Ritter
>> Assignee: Simone Tripodi
>> Priority: Minor
>> Attachments: SANDBOX-363.txt, SANDBOX-363v2.txt
>>
>>
>> Although the compiler should check that value is always of the correct type, a programmatic check should back this up.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jira] [Resolved] (SANDBOX-363) Check if value is of the correct
type in Argument.argument( Class type, V value )
Posted by Simone Tripodi <si...@apache.org>.
getParameterTypes is needed only when invoking constructors and
methods, BeanAccessor doesn't ned to access to that method because the
chain is
on( myBean ).invokeMethod( "equals" ).withArguments( ... )
the `withArguments` call is not not in BeanAccessor
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Sun, Jan 22, 2012 at 11:31 PM, Benedikt Ritter
<be...@systemoutprintln.de> wrote:
> Am 22.01.2012 22:32, schrieb Simone Tripodi (Resolved) (JIRA):
>>
>>
>> [
>> https://issues.apache.org/jira/browse/SANDBOX-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Simone Tripodi resolved SANDBOX-363.
>> ------------------------------------
>>
>> Resolution: Fixed
>> Assignee: Simone Tripodi
>>
>> patch applied, see
>> [r1234616|https://svn.apache.org/viewvc?view=revision&revision=1234616]
>>
>> as a side note: {{Argument.getParameterTypes}} is an internal method, I
>> moved the checks in the higher level, as soon as arguments need to be
>> checked, because invoked in constructors or methods.
>
>
> getParameterTypes has default visibility and for that reason can be used by
> other classes (for example BeanAccessor ;-). So I wouldn't exactly call it
> an internal method. Wouldn't it be better to leave the check in there?
>
>>
>> Thanks for contributing! ;)
>>
>>> Check if value is of the correct type in Argument.argument( Class<T>
>>> type, V value )
>>>
>>> ------------------------------------------------------------------------------------
>>>
>>> Key: SANDBOX-363
>>> URL: https://issues.apache.org/jira/browse/SANDBOX-363
>>> Project: Commons Sandbox
>>> Issue Type: Improvement
>>> Components: BeanUtils2
>>> Affects Versions: Nightly Builds
>>> Reporter: Benedikt Ritter
>>> Assignee: Simone Tripodi
>>> Priority: Minor
>>> Attachments: SANDBOX-363.txt, SANDBOX-363v2.txt
>>>
>>>
>>>
>>> Although the compiler should check that value is always of the correct
>>> type, a programmatic check should back this up.
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org