[jira] [Commented] (THRIFT-2522) TypeScript extension for Thrift Compiler

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993906#comment-13993906 ] 

ASF GitHub Bot commented on THRIFT-2522:
----------------------------------------

Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/119#issuecomment-42712665
  
    Great work Pascal!
    
    thanks for adding the required topic:
    https://issues.apache.org/jira/browse/THRIFT-2522
    
    could you please
    - add the apache license header to the lib/ts/thrift.d.ts file
    - close this pull request
    - create a new single commit with title *THRIFT-2522 TypeScript extension for Thrift Compiler*
    - create a new pull request with this commit or attach the patch to THRIFT-2522
    
    thanks
    -roger


> TypeScript extension for Thrift Compiler
> ----------------------------------------
>
>                 Key: THRIFT-2522
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2522
>             Project: Thrift
>          Issue Type: New Feature
>          Components: JavaScript - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Pascal Schweizer
>            Priority: Minor
>              Labels: features, javascript, typescript
>             Fix For: 0.9.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Add the possibility to generate TypeScript Definition Files in addition to the generated JavaScript code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)