You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2017/04/27 16:17:58 UTC

[GitHub] flink pull request #3792: [FLINK-6093][table] Implement and turn on retracti...

GitHub user hequn8128 opened a pull request:

    https://github.com/apache/flink/pull/3792

    [FLINK-6093][table] Implement and turn on retraction for table sink

    The PR mainly includes the following changes:
    1. Make `CRow` internal and revert all related code exposing `CRow`.
    2. Add needsUpdatesAsRetraction property to `StreamRetractSink`, and take TableSink into consideration during RetractionRule
    3. add support for output `Boolean` flag in `CRow`
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-6093] Implement and turn on retraction for table sink")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hequn8128/flink 6093

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3792
    
----
commit 6588f512f8ca40ee4182b67ac6c5b145b51b0d4b
Author: Hequn Cheng <ch...@gmail.com>
Date:   2017-04-27T15:03:44Z

    [FLINK-6093][table] Implement and turn on retraction for table sink

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3792: [FLINK-6093][table] Implement and turn on retraction for ...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3792
  
    Hi @hequn8128, I merged the PR to the `table-retraction` branch. 
    You can close this PR.
    
    Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3792: [FLINK-6093][table] Implement and turn on retracti...

Posted by hequn8128 <gi...@git.apache.org>.
Github user hequn8128 closed the pull request at:

    https://github.com/apache/flink/pull/3792


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---