You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/04/23 21:56:42 UTC
[GitHub] [madlib] njayaram2 commented on a change in pull request #373:
Changed default max_item_size to 10
njayaram2 commented on a change in pull request #373: Changed default max_item_size to 10
URL: https://github.com/apache/madlib/pull/373#discussion_r277888145
##########
File path: src/ports/postgres/modules/assoc_rules/assoc_rules.sql_in
##########
@@ -579,7 +579,7 @@ AS $$
input_table,
output_schema,
verbose,
- 'NULL');
+ 10);
$$ LANGUAGE plpythonu
Review comment:
The `if-elif` in https://github.com/apache/madlib/blob/master/src/ports/postgres/modules/assoc_rules/assoc_rules.py_in#L66 can be simplified to a single `if` statement due to this change, can you please update that code too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services