You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/22 12:20:25 UTC

[GitHub] [spark] srowen commented on a change in pull request #29836: [SPARK-32964][CORE][DSTREAMS] Pass all `streaming` module UTs in Scala 2.13

srowen commented on a change in pull request #29836:
URL: https://github.com/apache/spark/pull/29836#discussion_r492687623



##########
File path: streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala
##########
@@ -29,8 +28,8 @@ import org.apache.spark.util.Utils
 
 final private[streaming] class DStreamGraph extends Serializable with Logging {
 
-  private val inputStreams = new ArrayBuffer[InputDStream[_]]()
-  private val outputStreams = new ArrayBuffer[DStream[_]]()
+  private var inputStreams = Array.empty[InputDStream[_]]

Review comment:
       What about using mutable.Seq? does that also work?
   This probably is OK to use an Array as setting the streams isn't called many times though




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org