[GitHub] [spark] cloud-fan commented on a change in pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29021:
URL: https://github.com/apache/spark/pull/29021#discussion_r459835653



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -263,18 +299,31 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] {
     val shuffleStages = collectShuffleStages(plan)
 
     if (shuffleStages.length == 2) {

Review comment:
       why not we break this limitation first?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org