You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ma...@apache.org on 2022/05/10 23:17:34 UTC

[incubator-nuttx] 03/03: xtensa_sigtramp.S: Remove the ENTRY instruction.

This is an automated email from the ASF dual-hosted git repository.

masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 12453bb6234d89702e3a0989fab19142beb04b00
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Mon May 9 20:28:06 2022 +0200

    xtensa_sigtramp.S: Remove the ENTRY instruction.
    
    _xtensa_sig_trampoline is returned to after a context switch and not called
    by the usual Window call instructions (call4, call8 and call12),
    thus does not need the entry instruction.  Furthermore, the ENTRY instruction
    in this case is messing up the backtrace as it creates an extra frame.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 arch/xtensa/src/common/xtensa_sigtramp.S | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/xtensa/src/common/xtensa_sigtramp.S b/arch/xtensa/src/common/xtensa_sigtramp.S
index ba105db089..0c4f1aab38 100644
--- a/arch/xtensa/src/common/xtensa_sigtramp.S
+++ b/arch/xtensa/src/common/xtensa_sigtramp.S
@@ -26,8 +26,6 @@
 
 #include <nuttx/config.h>
 
-#include <arch/xtensa/xtensa_abi.h>
-
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -53,8 +51,6 @@
 	.align	4
 
 _xtensa_sig_trampoline:
-	ENTRY(16)						/* REVISIT: This should not be here */
-
 #ifdef __XTENSA_CALL0_ABI__
 	call0	xtensa_sig_deliver		/* Call xtensa_sig_deliver */
 #else