You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/09/16 04:04:50 UTC

[I] test(runtime): late ConPTY PID fixture races its trailing newline [maka]

seekskyworld opened a new issue, #5372:
URL: https://github.com/apache/maka/issues/5372

   ### What happened
   
   The existing `persists a late ConPTY PID on ... without new output` Runtime tests can fail even though PID persistence is correct. The fixture writes `READY\n` and waits only for `/READY/` before saving a baseline terminal snapshot. PTY delivery may split the readiness text from the trailing CR/LF, so the later snapshot has the same `READY` text but a different cursor.
   
   This failed in an unrelated two-file filesystem-write PR, #5371: [CI failure](https://github.com/apache/maka/actions/runs/35053491215/job/104658675468). Only the exit case failed in that run; the expected cursor was `{x:5,y:0}`, actual `{x:0,y:1}`. The test and ShellRun production path were unchanged by that PR.
   
   Expected: the readiness condition must establish that all fixture output has arrived before comparing snapshots across the PID-only transition.
   
   ### How to reproduce
   
   The ordinary test is intermittent; ten local repeats of the current fixture passed. A deterministic local probe reproduced both the read and exit variants:
   
   1. Run the two `persists a late ConPTY PID` cases.
   2. At the PTY driver's existing data-callback boundary, deliver the bytes through `READY` and hold any following bytes.
   3. Release the held suffix when the test next observes the real native PID, after it captures its baseline snapshot.
   4. Both original tests fail with the same cursor difference as CI.
   
   This is a permissible fragmentation of the fixture's original PTY byte stream. With a fixture that writes only `READY`, the same forced delivery schedule passes both cases. No PID, output-equality, or process-lifecycle assertions need to be weakened, and no sleep or increased timeout is needed.
   
   ### Environment
   
   - Main: `27add3049`
   - CI failure: Ubuntu GitHub Actions, PR #5371 head `408fe0aa7`
   - Deterministic local probe: macOS arm64, Node 24.18.1
   - Surface: Runtime `shell-run-manager.test.ts`
   
   ### Logs, screenshots, or additional context
   
   ```
   expected.output.screen = actual.output.screen = 'READY'
   expected.output.cursor = { x: 5, y: 0, visible: true }
   actual.output.cursor   = { x: 0, y: 1, visible: true }
   ```
   
   The fix is to emit a readiness marker with no trailing control bytes in these two PID-only tests. Other tests still exercise normal newline output.
   
   Automated report: OpenAI Codex investigated the hosted failure and verified the forced-fragmentation reproduction during the contributor's requested audit.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] test(runtime): late ConPTY PID fixture races its trailing newline [maka]

Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on issue #5372:
URL: https://github.com/apache/maka/issues/5372#issuecomment-5691868306

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] test(runtime): late ConPTY PID fixture races its trailing newline [maka]

Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld closed issue #5372: test(runtime): late ConPTY PID fixture races its trailing newline
URL: https://github.com/apache/maka/issues/5372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] test(runtime): late ConPTY PID fixture races its trailing newline [maka]

Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on issue #5372:
URL: https://github.com/apache/maka/issues/5372#issuecomment-6095713557

   Resolved on main by #5410 (b062b40c4): readiness now waits for the newline’s cursor movement before taking the output snapshot. Both late-ConPTY-PID read/exit cases pass, and the full current ShellRun suite passes 63 tests with 4 platform skips on Node 24.18.1. My earlier alternative #5373 is redundant and has been closed.
   
   Automated update by OpenAI Codex under the contributor’s direction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org