[jira] [Commented] (HIVE-15668) change REPL DUMP syntax to use "LIMIT" instead of "BATCH" keyword

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-15668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878801#comment-15878801 ] 

Hive QA commented on HIVE-15668:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853928/HIVE-15668.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10238 tests executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver (batchId=101)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3694/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3694/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3694/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12853928 - PreCommit-HIVE-Build

> change REPL DUMP syntax to use "LIMIT" instead of "BATCH" keyword
> -----------------------------------------------------------------
>
>                 Key: HIVE-15668
>                 URL: https://issues.apache.org/jira/browse/HIVE-15668
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-15668.2.patch, HIVE-15668.patch
>
>
> Currently, REPL DUMP syntax goes:
> {noformat}
> REPL DUMP [<dbname>[.<tblname>]] [FROM <eventid> [BATCH <batchSize>]]
> {noformat}
> The BATCH directive says that when doing an event dump, to not dump out more than _batchSize_ number of events. However, there is a clearer keyword for the same effect, and that is LIMIT. Thus, rephrasing the syntax as follows makes it clearer:
> {noformat}
> REPL DUMP [<dbname>[.<tblname>]] [FROM <eventid> [LIMIT <maxEventLimit>]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)