You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2018/01/23 23:46:00 UTC
[jira] [Comment Edited] (YARN-7757) Refactor NodeLabelsProvider to
be more generic and reusable for node attributes providers
[ https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331752#comment-16331752 ]
Weiwei Yang edited comment on YARN-7757 at 1/23/18 11:45 PM:
-------------------------------------------------------------
Hi [~Naganarasimha]
Thanks for taking time looking into this. Like I commented in [Distributed node attributes v1|https://issues.apache.org/jira/secure/attachment/12906152/Distributed%20node%20attributes%20v1.pdf]. I was proposing to get node-attributes fully distributed. So I was suggesting to let NM be able to manage its own attributes, via
# A script provider
# Admin interface
So NM needs to gets the attributes from 2 providers and merge them then send to RM. That was why the patch allows parallel providers. The refactor works also fine if there is only 1 provider configured for the NM attribute manager, that's the 1st step we are going to accomplish.
{quote}IMO we need to incorporate the same classes to fetch the additional details for attributes too.
{quote}
The refactor in the patch was trying to make PROVIDER interface more general, as having a DESCRIPTOR concept, it's easy to extend labels and attributes with existing code base. It's odd to use same classes for attributes to me, that's why I proposed this refactor.
was (Author: cheersyang):
Hi [~Naganarasimha]
Thanks for taking time looking into this. Like I commented in [^Distributed node attributes v1.pdf], and this comment. I was proposing to get node-attributes fully distributed. So I was suggesting to let NM be able to manage its own attributes, via
# A script provider
# Admin interface
So NM needs to gets the attributes from 2 providers and merge them then send to RM. That was why the patch allows parallel providers. The refactor works also fine if there is only 1 provider configured for the NM attribute manager, that's the 1st step we are going to accomplish.
{quote}IMO we need to incorporate the same classes to fetch the additional details for attributes too.
{quote}
The refactor in the patch was trying to make PROVIDER interface more general, as having a DESCRIPTOR concept, it's easy to extend labels and attributes with existing code base. It's odd to use same classes for attributes to me, that's why I proposed this refactor.
> Refactor NodeLabelsProvider to be more generic and reusable for node attributes providers
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7757
> URL: https://issues.apache.org/jira/browse/YARN-7757
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-7757-YARN-3409.001.patch, YARN-7757-YARN-3409.002.patch, nodeLabelsProvider_refactor_class_hierarchy.pdf
>
>
> Propose to do refactor on {{NodeLabelsProvider}}, {{AbstractNodeLabelsProvider}} to be more generic, so node attributes providers can reuse these interface/abstract classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org