You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Xiening Dai (Jira)" <ji...@apache.org> on 2020/02/19 23:09:00 UTC

[jira] [Created] (CALCITE-3807) checkForSatisfiedConverters() is unnecessary

Xiening Dai created CALCITE-3807:
------------------------------------

             Summary: checkForSatisfiedConverters() is unnecessary 
                 Key: CALCITE-3807
                 URL: https://issues.apache.org/jira/browse/CALCITE-3807
             Project: Calcite
          Issue Type: Bug
            Reporter: Xiening Dai


When VolcanoPlanner registers an abstract converter, it adds the converter into set.abstractConverters list, then calls checkSatisfiedConverter() to see if any converter is satisfied and can be remove from the list. But for every abstract converter, it always satisfies itself (changeTraitsUsingConverters() returns itself). Basically the converter would be removed from the list right after it's added. So this check is completely unnecessary and it slows down the planner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)