[I] Edit Connection form crashes silently when connection has invalid extra JSON [airflow]

["shashbha14 (via GitHub)" <gi...@apache.org>]

shashbha14 opened a new issue, #66591:
URL: https://github.com/apache/airflow/issues/66591

   ### Under which category would you file this issue?
   
   Airflow Core
   
   ### Apache Airflow version
   
   3.2.1
   
   ### What happened and how to reproduce it?
   
   I have found that the JSON.parse() function call in ConnectionForm.tsx on line 
   85 does not have a try-catch block around it:
   setConf(JSON.stringify(JSON.parse(initialConnection.extra), undefined, 2));
   Thus, any connections with invalid JSON inside the extra object will cause 
   an exception to be thrown when opening the form. This issue can be easily 
   solved using the code from line 103 to 110 in the same file.
   Reproducibility:
   1. Create a new connection with invalid JSON inside the extra object
   2. Attempt to open Edit Connection form
   
   
   
   ### What you think should happen instead?
   
   Edit form should work properly.
   
   ### Operating System
   
   Not applicable
   
   ### Deployment
   
   Other
   
   ### Apache Airflow Provider(s)
   
   _No response_
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Official Helm Chart version
   
   Not Applicable
   
   ### Kubernetes Version
   
   Not Applicable
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customizations
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Edit Connection form crashes silently when connection has invalid extra JSON [airflow]

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi closed issue #66591: Edit Connection form crashes silently when connection has invalid extra JSON
URL: https://github.com/apache/airflow/issues/66591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org