You are viewing a plain text version of this content. The canonical link for it is here.
Posted to m2-dev@maven.apache.org by ji...@codehaus.org on 2005/01/10 03:54:27 UTC
[jira] Commented: (MNG-107) Eclipse Plugin Tests are failing.
The following comment has been added to this issue:
Author: Trygve Laugstol
Created: Sun, 9 Jan 2005 9:54 PM
Body:
1: Please attach the issue as a file. Makes it easier to grab with wget.
2: Why did you change the parent pom? Shouldn't be any reason for that.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MNG-107?page=comments#action_28791
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MNG-107
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MNG-107
Summary: Eclipse Plugin Tests are failing.
Type: Bug
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: m2
Assignee:
Reporter: Mauro Botelho
Created: Sun, 9 Jan 2005 9:50 PM
Updated: Sun, 9 Jan 2005 9:54 PM
Description:
The eclipse plugin tests are failing due to dependencies upgrades. Here's the patch to the tests.
Index: pom.xml
===================================================================
RCS file: /scm/mojo/mojo/maven-eclipse-plugin/pom.xml,v
retrieving revision 1.7
diff -u -r1.7 pom.xml
--- pom.xml 8 Jan 2005 02:21:58 -0000 1.7
+++ pom.xml 10 Jan 2005 02:49:36 -0000
@@ -3,9 +3,9 @@
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>mojo</groupId>
- <artifactId>mojo</artifactId>
- <version>1.0-SNAPSHOT</version>
+ <groupId>maven</groupId>
+ <artifactId>maven-plugin-parent</artifactId>
+ <version>2.0-SNAPSHOT</version>
</parent>
<groupId>maven</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
@@ -23,5 +23,10 @@
<artifactId>maven-model</artifactId>
<version>2.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>plexus</groupId>
+ <artifactId>plexus-utils</artifactId>
+ <version>1.0-alpha-1-SNAPSHOT</version>
+ </dependency>
</dependencies>
</project>
Index: src/test/java/org/apache/maven/plugin/eclipse/EclipsePluginTest.java
===================================================================
RCS file: /scm/mojo/mojo/maven-eclipse-plugin/src/test/java/org/apache/maven/plugin/eclipse/EclipsePluginTest.java,v
retrieving revision 1.7
diff -u -r1.7 EclipsePluginTest.java
--- src/test/java/org/apache/maven/plugin/eclipse/EclipsePluginTest.java 16 Sep 2004 13:38:24 -0000 1.7
+++ src/test/java/org/apache/maven/plugin/eclipse/EclipsePluginTest.java 10 Jan 2005 02:49:36 -0000
@@ -25,11 +25,11 @@
import java.util.List;
import java.util.Map;
+import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.plugin.PluginExecutionRequest;
import org.apache.maven.plugin.PluginExecutionResponse;
import org.apache.maven.project.MavenProject;
import org.apache.maven.project.MavenProjectBuilder;
-
import org.codehaus.plexus.ArtifactEnabledPlexusTestCase;
import org.codehaus.plexus.util.StringUtils;
@@ -56,7 +56,7 @@
throws Exception
{
File basedir = getTestFile( "src/test/projects/" + projectName );
-
+
MavenProjectBuilder builder = (MavenProjectBuilder) lookup( MavenProjectBuilder.ROLE );
EclipsePlugin plugin = new EclipsePlugin();
@@ -66,10 +66,12 @@
PluginExecutionResponse response = new PluginExecutionResponse();
File repo = getTestFile( "src/test/repository" );
+
+ ArtifactRepository localRepository = new ArtifactRepository("local", "file://" + repo.getAbsolutePath());
System.setProperty( "maven.repo.local", repo.getAbsolutePath() );
-
- MavenProject project = builder.build( new File( basedir, "project.xml" ), true );
+
+ MavenProject project = builder.build( new File( basedir, "project.xml" ), localRepository, true );
Map params = new HashMap();
@@ -81,9 +83,9 @@
plugin.execute( request, response );
- assertFileEquals( project.getLocalRepository().getBasedir(), new File( basedir, "project" ), new File( basedir, ".project" ) );
+ assertFileEquals( localRepository.getBasedir(), new File( basedir, "project" ), new File( basedir, ".project" ) );
- assertFileEquals( project.getLocalRepository().getBasedir(), new File( basedir, "classpath" ), new File( basedir, ".classpath" ) );
+ assertFileEquals( localRepository.getBasedir(), new File( basedir, "classpath" ), new File( basedir, ".classpath" ) );
}
private void assertFileEquals( String mavenRepo, File expectedFile, File actualFile )
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira