You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2023/06/20 05:56:17 UTC

[GitHub] [pulsar] Technoboy- opened a new pull request, #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Technoboy- opened a new pull request, #20614:
URL: https://github.com/apache/pulsar/pull/20614

   
   ### Motivation
   After configuring the geo-replication on Pulsar clusters, the `clusters list` API will return multiple clusters, including the local Pulsar cluster and remote clusters like 
   
   ```
   bin/pulsar-admin clusters list
   us-west
   us-east
   us-cent
   ```
   But in this return, you can't distinguish the local and the remote cluster. When you need to remove the geo-replication configuration, it will be hard to decide which cluster should be removed on replicated tenants and namespaces unless you record the cluster information. 
   
   
   ### Modification
   Add `local` flag to distinguish clusters
   ```
   bin/pulsar-admin clusters list
   us-west(local)
   us-east
   us-cent
   ```
   
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1605914016

   > > It will be more convinient to group by `local` vs `remote`
   > 
   > I think this is a good idea to distinguish between `local` and `remote` types.
   > 
   > ```
   > # list remote clusters
   > bin/pulsar-admin clusters list --remote
   > # list local clustes
   > bin/pulsar-admin clusters list --local
   > # list all clusters
   > bin/pulsar-admin clusters list
   > ```
   
   Good idea, could you also discuss this in this [mail](https://lists.apache.org/thread/800r6ld5wg7bttbywmk38m1qx12hs6nl) ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #20614: [improve][pip] PIP-277: Add `current` option in the Clusters list cmd

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1709371168

   > Why did you move `pip-274.md`? I see that the same change also appears in https://github.com/apache/pulsar/pull/20993/files.
   
   `pip-274.md` should rename to `pip-276.md`. Then in #20993, I have done it. So no need to update in this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] JooHyukKim commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1605827636

   @Technoboy- For sure, will do.👍🏻


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #20614: [improve][pip] PIP-277: Add `current` option in the Clusters list cmd

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20614:
URL: https://github.com/apache/pulsar/pull/20614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #20614: [pip][design] PIP-277: Add `--current` option in the Clusters list cmd

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1654858562

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1605838697

   > It will be more convinient to group by `local` vs `remote`
   
   I think this is a good idea to distinguish between `local` and `remote` types.
   
   ```
   # list remote clusters
   bin/pulsar-admin clusters list --remote
   # list local clustes
   bin/pulsar-admin clusters list --local
   # list all clusters
   bin/pulsar-admin clusters list
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] JooHyukKim commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1599025705

   > Add local flag to distinguish clusters
   
   Would you consider adding `remote` flag also, @Technoboy- ? It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community) 🤔 Plus users will benefit from not having to think about what `non-local` clusters are called. 
   
   Possible use-case would be someone automates counting how many remotes and clusters are there in list via shellscript, or 
   simple String parser. It will be more convinient to group by `local` vs `remote`, rather than `local` vs `""`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1605827474

   > > Add local flag to distinguish clusters
   > 
   > Would you consider adding `remote` flag also, @Technoboy- ? 🙂 It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community) 🤔 Plus users will benefit from not having to think about what `non-local` clusters are called.
   > 
   > Possible use-case would be someone automates counting how many remotes and clusters are there in list via shellscript, or simple String parser. It will be more convinient to group by `local` vs `remote`, rather than `local` vs `""`
   
   yes, sure. Could you also send these ideas in this [mail](https://lists.apache.org/thread/800r6ld5wg7bttbywmk38m1qx12hs6nl) ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] JooHyukKim commented on pull request #20614: [pip][design] PIP-277: Clusters list API return clusters with local flag

Posted by "JooHyukKim (via GitHub)" <gi...@apache.org>.
JooHyukKim commented on PR #20614:
URL: https://github.com/apache/pulsar/pull/20614#issuecomment-1605839001

   +1 on @nodece 's proposal wrt `--local` and `--remote` flag 👍🏻


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org