[GitHub] [lucene-solr] jimczi commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination

[GitBox <gi...@apache.org>]

jimczi commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination
URL: https://github.com/apache/lucene-solr/pull/897#discussion_r327455335
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
 ##########
 @@ -276,7 +283,20 @@ protected void updateMinCompetitiveScore(Scorable scorer) throws IOException {
           && pqTop.score != Float.NEGATIVE_INFINITY) { // -Infinity is the score of sentinels
       // since we tie-break on doc id and collect in doc id order, we can require
       // the next float
-      scorer.setMinCompetitiveScore(Math.nextUp(pqTop.score));
+      float bottomScore = Math.nextUp(pqTop.score);
+
+      if (bottomValueChecker != null && bottomValueChecker.getBottomValue() > 0) {
 
 Review comment:
   Why do you need to check that the value is greater than 0 ? It seems that it prevents the updating of the global minimum score since the value is always 0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org