You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/27 12:48:50 UTC
[GitHub] [ozone] tanvipenumudy opened a new pull request, #3555: HDDS-6956. Reposition ozoneLockProvider initialization in OzoneManager
tanvipenumudy opened a new pull request, #3555:
URL: https://github.com/apache/ozone/pull/3555
## What changes were proposed in this pull request?
Reposition the initialization of `ozoneLockProvider`:
`ozoneLockProvider = new OzoneLockProvider(getKeyPathLockEnabled(), getEnableFileSystemPaths())`
currently present at [OzoneManager.java#L1545](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L1545) below `metadataManager.start(configuration)` at [OzoneManager.java#L1468](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L1468).
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6956
## How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3555: HDDS-6956. Reposition ozoneLockProvider initialization in OzoneManager
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3555:
URL: https://github.com/apache/ozone/pull/3555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3555: HDDS-6956. Reposition ozoneLockProvider initialization in OzoneManager
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3555:
URL: https://github.com/apache/ozone/pull/3555#discussion_r929092196
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1467,6 +1467,9 @@ public void start() throws IOException {
metadataManager.start(configuration);
+ ozoneLockProvider = new OzoneLockProvider(getKeyPathLockEnabled(),
+ getEnableFileSystemPaths());
Review Comment:
Would it be possible to move it to the constructor, anywhere after `setConfiguration()`? Both `getKeyPathLockEnabled()` and `getEnableFileSystemPaths()` rely only on the member variable `configuration`. `ozoneLockProvider` could be `final`, too.
https://github.com/apache/ozone/blob/11cdb25fecb62519462901de7f46bac5b10af701/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L438-L442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3555: HDDS-6956. Reposition ozoneLockProvider initialization in OzoneManager
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3555:
URL: https://github.com/apache/ozone/pull/3555#discussion_r929092196
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1467,6 +1467,9 @@ public void start() throws IOException {
metadataManager.start(configuration);
+ ozoneLockProvider = new OzoneLockProvider(getKeyPathLockEnabled(),
+ getEnableFileSystemPaths());
Review Comment:
Would it be possible to move it to the constructor, anywhere after `setConfiguration()`? Both `getKeyPathLockEnabled()` and `getEnableFileSystemPaths()` rely only on the member variable `configuration`.
https://github.com/apache/ozone/blob/11cdb25fecb62519462901de7f46bac5b10af701/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L438-L442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] tanvipenumudy commented on a diff in pull request #3555: HDDS-6956. Reposition ozoneLockProvider initialization in OzoneManager
Posted by GitBox <gi...@apache.org>.
tanvipenumudy commented on code in PR #3555:
URL: https://github.com/apache/ozone/pull/3555#discussion_r929102389
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1467,6 +1467,9 @@ public void start() throws IOException {
metadataManager.start(configuration);
+ ozoneLockProvider = new OzoneLockProvider(getKeyPathLockEnabled(),
+ getEnableFileSystemPaths());
Review Comment:
Thank you, I have made the changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org