You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Randy Abernethy (JIRA)" <ji...@apache.org> on 2015/07/21 00:40:05 UTC

[jira] [Updated] (THRIFT-3250) Apache Thrift should use registered media types with HTTP

     [ https://issues.apache.org/jira/browse/THRIFT-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randy Abernethy updated THRIFT-3250:
------------------------------------
    Description: 
Now that we have registered media types:
- application/vnd.apache.thrift.binary
- application/vnd.apache.thrift.compact
- application/vnd.apache.thrift.json

We should use them exclusively, replacing the old x-thrift. I suggest TProtocol gain a getMediaType() method which returns the correct media type when invoked on a concrete protocol (e.g. TBinaryProtocol.getMediaType() would return "application/vnd.apache.thrift.binary".

HTTP oriented code can then invoke the getMediaType() method of the protocol to discover the correct media type to set in HTTP headers. 

Thoughts?

  was:
Now that we have registered media types:
- application/vnd.apache.thrift.binary
- application/vnd.apache.thrift.compact
- application/vnd.apache.thrift.json

We should use them exclusively, replacing the old x-thrift. I suggest TProtocol gain a getMediaType() method which returns the correct media type when invoked on a concrete media type (e.g. TBinaryProtocol.getMediaType() would return "application/vnd.apache.thrift.binary".

HTTP oriented code can then invoke the getMediaType() method of the protocol to discover the correct media type to set in HTTP headers. 

Thoughts?


> Apache Thrift should use registered media types with HTTP
> ---------------------------------------------------------
>
>                 Key: THRIFT-3250
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3250
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library, C++ - Library, Java - Library, JavaScript - Library, Node.js - Library
>    Affects Versions: 0.9.3
>         Environment: all
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> Now that we have registered media types:
> - application/vnd.apache.thrift.binary
> - application/vnd.apache.thrift.compact
> - application/vnd.apache.thrift.json
> We should use them exclusively, replacing the old x-thrift. I suggest TProtocol gain a getMediaType() method which returns the correct media type when invoked on a concrete protocol (e.g. TBinaryProtocol.getMediaType() would return "application/vnd.apache.thrift.binary".
> HTTP oriented code can then invoke the getMediaType() method of the protocol to discover the correct media type to set in HTTP headers. 
> Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)