You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2021/12/30 07:59:55 UTC
[GitHub] [incubator-seatunnel] kezhenxu94 opened a new issue #905: [License] check dependencies' binary licenses
kezhenxu94 opened a new issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905
### Search before asking
- [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
### Description
Currently https://github.com/apache/incubator-seatunnel/blob/dev/tools/dependencies/known-dependencies.txt takes no effect, we have bad case like #855 that doesn't address the new dependencies `jcommander` correctly. We need to find a way to address this case.
### Usage Scenario
Dependencies should be checked although they were packed into a fat jar
### Related issues
#jcommand
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002914333
@CalvinKirs are you interested in working this with me together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002915513
> @CalvinKirs are you interested in working this with me together?
Very honored~
The current dep-license file is not perfect, and there is no check mechanism at the same time. I don't know how to check the shade package license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002916104
I may need to spend some time looking at how other projects are done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie closed issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 edited a comment on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002917649
The problem now is that we don't have a list of the dependencies, once we got the list, we can reuse the script https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
Even we can have the dependencies from final .tgz, we can have another command to copy the dependencies that this project uses, like
```shell
./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
```
So we can generate the same file `all-dependencies.txt` like the one in https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh , with
```shell
ls /tmp/seatunnel-dependencies > all-dependencies.txt
```
then everything else is the same as https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002919257
> The problem now is that we don't have a list of the dependencies, once we got the list, we can reuse the script https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
>
> Even we can have the dependencies from final .tgz, we can have another command to copy the dependencies that this project uses, like
>
> ```shell
> ./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
> ```
>
> So we can generate the same file `all-dependencies.txt` like the one in https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh , with
>
> ```shell
> ls /tmp/seatunnel-dependencies > all-dependencies.txt
> ```
>
> then everything else is the same as https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
deeply thanks~ let me try do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on issue #905: [License] check dependencies' binary licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #905:
URL: https://github.com/apache/incubator-seatunnel/issues/905#issuecomment-1002917649
The problem now is that we don't have a list of the dependencies, once we got the list, we can reuse the script https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
Even we can have the dependencies from final .tgz, we can have another command to copy the dependencies that this project uses, like
```shell
./mvnw dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=/tmp/seatunnel-dependencies
```
So we can generate the same file `third-party-dependencies.txt` like the one in https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh , with
```shell
ls /tmp/seatunnel-dependencies > third-party-dependencies.txt
```
then everything else is the same as https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/check-LICENSE.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org