You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rajujith (via GitHub)" <gi...@apache.org> on 2023/11/08 06:02:54 UTC
[I] Featured private templates [cloudstack]
rajujith opened a new issue, #8195:
URL: https://github.com/apache/cloudstack/issues/8195
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
Templates
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.18.1, ALL
~~~
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Currently, CloudStack expects the featured templates to be public as well if they are not public the featured templates are not listed in the featured templates tab in UI. Either in the template filter 'Featured' in the Images pane or in the instance deployment wizard. Why featured templates are tied to the property 'public' can this dependency be removed to allow private templates as well as Featured ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2157543122
@rajujith @shwstppr @DaanHoogland @sureshanaparti
according to the source code, it looks featured templates must be public
https://github.com/apache/cloudstack/blob/4.19.0.1/api/src/main/java/com/cloud/template/VirtualMachineTemplate.java#L71-L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160621081
thanks @rajujith
since this is an improvement, moving to 4.20.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith closed issue #8195: Featured private templates
URL: https://github.com/apache/cloudstack/issues/8195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-1801843945
@rajujith i marked this as bug as the api also does not show featured non-public templates when using `templatefilter=featured`, but does when using `templatefilter=all`.
I actually think we should be able to directly list on the basis of the flags, i.e. `ispublic=false` or `isfeatured=true`. Wgat do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160531614
The improvement required here is to implement featured private template types where a user wants to list private /non public templates as featured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2102172370
listTempalates API currently doesn't have `ispublic` or `isfeatured` parameters. Also, I'm not in favour of adding such new parameter as it would add confusion to the existing `templatefilter` parameter.
I feel we should be able to fix the issue listing non-public featured template by removing this condition,
https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L4505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160563758
@weizhouapache how about 'spotlight'? or just 'featured private'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160913492
@weizhouapache can we extend the featured feature (bad pun unintended) to include the callers featured private templates, or should it really be a separate feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-1803411722
@DaanHoogland I do agree to list directly on the basis of the flags `ispublic=false` or `isfeatured=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160543411
> The improvement required here is to implement featured private template types where a user wants to list private /non public templates as featured.
THANKS @rajujith
can you suggest the name of the new template filters ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Featured private templates [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #8195:
URL: https://github.com/apache/cloudstack/issues/8195#issuecomment-2160919037
> @weizhouapache can we extend the featured feature (bad pun unintended) to include the callers featured private templates, or should it really be a separate feature?
@DaanHoogland
I would suggest to add new template filters for
- private-featured
- private-non-featured
at first we need to have a consensus on the names.
for me, it looks like a small improvement with low priority
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org