You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/03 00:35:35 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Shoothzj opened a new pull request, #3255:
URL: https://github.com/apache/bookkeeper/pull/3255
Fix #3243
### Motivation
Allow run LocalBookkeeper directly on IDE. It's typicaly useful for beginners or who want to figure out how bookkeeper works.
### Changes
- change `snappy-java` and `metrics-core` scope from test to runtime
### What's different in the jar built there/shell scripts that launch it
we have scope compile dependency in `bookkeeper-dist-server`, so the shell goes well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#discussion_r864535970
##########
bookkeeper-server/pom.xml:
##########
@@ -123,6 +123,19 @@
<groupId>io.reactivex.rxjava3</groupId>
<artifactId>rxjava</artifactId>
</dependency>
+ <!-- used on test and main method like `LocalBookKeeper` -->
+ <dependency>
+ <!-- needed by ZooKeeper server -->
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
+ <scope>runtime</scope>
Review Comment:
@eolivelli I haven't test it. Let me test it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#issuecomment-1117036173
@eolivelli you are definitely right! We need mark this dependency optional. Please take a look again.
@dlg99 @merlimat @pkumar-singh @nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#issuecomment-1116875687
@eolivelli @dlg99 @merlimat @pkumar-singh @nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#issuecomment-1115499987
@eolivelli @merlimat @pkumar-singh @nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#discussion_r864534753
##########
bookkeeper-server/pom.xml:
##########
@@ -123,6 +123,19 @@
<groupId>io.reactivex.rxjava3</groupId>
<artifactId>rxjava</artifactId>
</dependency>
+ <!-- used on test and main method like `LocalBookKeeper` -->
+ <dependency>
+ <!-- needed by ZooKeeper server -->
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
+ <scope>runtime</scope>
Review Comment:
is this dependency imported to downstream client applications ?
did you test it ?
probably we will need to add "optional"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org