[GitHub] andrewfayres commented on a change in pull request #12772: [MXNET-984] Add Java NDArray and introduce Java Operator Builder class

[GitBox <gi...@apache.org>]

andrewfayres commented on a change in pull request #12772: [MXNET-984] Add Java NDArray and introduce Java Operator Builder class
URL: https://github.com/apache/incubator-mxnet/pull/12772#discussion_r224356345
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/javaapi/DType.scala
 ##########
 @@ -24,4 +24,6 @@ object DType extends Enumeration {
   val UInt8 = org.apache.mxnet.DType.UInt8
   val Int32 = org.apache.mxnet.DType.Int32
   val Unknown = org.apache.mxnet.DType.Unknown
+
+  private[mxnet] def numOfBytes(dType: DType): Int = org.apache.mxnet.DType.numOfBytes(dType)
 
 Review comment:
   This looks like an unused private method. I think we can get rid of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services