You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/08/22 02:42:08 UTC

[GitHub] incubator-weex pull request #625: * [android] fix wrong draw on first downlo...

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/625

    * [android] fix wrong draw on first download iconfont

    Testcase: http://dotwe.org/vue/6ece072d0abd9a9e5718eb26bd5719f8
    
    **NOTE: .woff font not supported in Android Nougat**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-bugfix-load-iconfont

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #625
    
----
commit b4b7c919ce4157e1d356f7b863580b6bcfdead7c
Author: misakuo <mi...@apache.org>
Date:   2017-08-22T02:35:52Z

    * [android] fix wrong draw on first download iconfont

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #625: * [android] fix wrong draw on first download icon...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/625
  
    
    <!--
      1 failure:  This PR modify SD...
      2 warning:  No Changelog chan..., This PR should up...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @YorkShen , @LeeJay0226 to be the reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #625: * [android] fix wrong draw on first downlo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/625


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---