You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/06/14 08:24:49 UTC
[PR] [SPARK-48629] Migrate the remaining code to structured logging framework [spark]
panbingkun opened a new pull request, #46986:
URL: https://github.com/apache/spark/pull/46986
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650257543
##########
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##########
@@ -299,9 +301,8 @@ private[spark] object LogKeys {
case object HIVE_OPERATION_STATE extends LogKey
case object HIVE_OPERATION_TYPE extends LogKey
case object HOST extends LogKey
+ case object HOSTS extends LogKey
case object HOST_LOCAL_BLOCKS_SIZE extends LogKey
- case object HOST_NAME extends LogKey
Review Comment:
Let's unify `HOST_NAME` to `HOST` and remove `HOST_NAME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650266142
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/MasterWebUI.scala:
##########
@@ -79,7 +79,7 @@ class MasterWebUI(
} else {
val removedWorkers = masterEndpointRef.askSync[Integer](
DecommissionWorkersOnHosts(hostnames))
- logInfo(log"Decommissioning of hosts ${MDC(HOST_NAMES, hostnames)}" +
+ logInfo(log"Decommissioning of hosts ${MDC(HOSTS, hostnames)}" +
Review Comment:
Let's unify it as `HOSTS`, there is a detailed explanation below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650284734
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/Operation.java:
##########
@@ -290,7 +290,7 @@ protected void cleanupOperationLog() {
if (operationLog == null) {
LOG.error("Operation [ {} ] logging is enabled, " +
"but its OperationLog object cannot be found.",
- MDC.of(LogKeys.OPERATION_HANDLE_IDENTIFIER$.MODULE$, opHandle.getHandleIdentifier()));
Review Comment:
Let's abbreviate `IDENTIFIER` as `ID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the remaining code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46986:
URL: https://github.com/apache/spark/pull/46986#issuecomment-2167537372
In addition, I have also found similar issues in the `core` module, but currently there seems to be a PR https://issues.apache.org/jira/browse/SPARK-47579 still in progress, so to prevent conflicts, I skipped it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650276697
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -869,7 +868,7 @@ private[spark] class ApplicationMaster(
}
} else {
logError(log"Application Master lost connection with driver! Shutting down. " +
- log"${MDC(LogKeys.REMOTE_ADDRESS, remoteAddress)}")
+ log"${MDC(LogKeys.HOST_PORT, remoteAddress)}")
Review Comment:
I remember there was a PR before that had already unified `REMOTE_ADDRESS` as `HOST_PORT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650265621
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -83,7 +83,7 @@ private[spark] class Executor(
extends Logging {
logInfo(log"Starting executor ID ${LogMDC(LogKeys.EXECUTOR_ID, executorId)}" +
- log" on host ${LogMDC(HOST_NAME, executorHostname)}")
+ log" on host ${LogMDC(HOST, executorHostname)}")
Review Comment:
https://github.com/apache/spark/blob/e972daec30eb34e9352f37e9ac74db77a895d679/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala#L765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46986:
URL: https://github.com/apache/spark/pull/46986#issuecomment-2185448950
Let me double check myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46986:
URL: https://github.com/apache/spark/pull/46986#issuecomment-2185516712
@gengliangwang
It's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650274581
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala:
##########
@@ -176,8 +176,7 @@ class StateStoreChangelogWriterV1(
} catch {
case e: Throwable =>
abort()
- logError(log"Fail to commit changelog file ${MDC(LogKeys.FILE_NAME, file)} " +
Review Comment:
Let's call it `PATH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650286611
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetFunctionsOperation.scala:
##########
@@ -51,9 +51,11 @@ private[hive] class SparkGetFunctionsOperation(
override def runInternal(): Unit = {
// Do not change cmdStr. It's used for Hive auditing and authorization.
- val cmdStr = s"catalog : $catalogName, schemaPattern : $schemaName"
- val logMsg = s"Listing functions '$cmdStr, functionName : $functionName'"
- logInfo(log"${MDC(LogKeys.MESSAGE, logMsg)} with ${MDC(LogKeys.STATEMENT_ID, statementId)}")
Review Comment:
expand `logMsg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the remaining code to structured logging framework [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #46986:
URL: https://github.com/apache/spark/pull/46986#issuecomment-2183516914
@panbingkun Could you update this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650282331
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala:
##########
@@ -373,8 +372,7 @@ abstract class StreamExecution(
case _ => None
}
- logError(log"Query ${MDC(LogKeys.PRETTY_ID_STRING, prettyIdString)} " +
- log"terminated with error", e)
+ logError(log"Query ${MDC(QUERY_ID, prettyIdString)} terminated with error", e)
Review Comment:
Let's restore it, I misread it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650266656
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListenerBus.scala:
##########
@@ -145,13 +145,11 @@ class StreamingQueryListenerBus(sparkSession: SparkSession) extends Logging {
case t: QueryTerminatedEvent =>
listener.onQueryTerminated(t)
case _ =>
- logWarning(
- log"Unknown StreamingQueryListener event: " +
- log"${MDC(LogKeys.EVENT, event)}")
+ logWarning(log"Unknown StreamingQueryListener event: ${MDC(LogKeys.EVENT, event)}")
Review Comment:
Make our code format look pretty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650257690
##########
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##########
@@ -299,9 +301,8 @@ private[spark] object LogKeys {
case object HIVE_OPERATION_STATE extends LogKey
case object HIVE_OPERATION_TYPE extends LogKey
case object HOST extends LogKey
+ case object HOSTS extends LogKey
case object HOST_LOCAL_BLOCKS_SIZE extends LogKey
- case object HOST_NAME extends LogKey
- case object HOST_NAMES extends LogKey
Review Comment:
Let's unify `HOST_NAMES` to `HOSTS` and remove `HOST_NAMES`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650286349
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetFunctionsOperation.scala:
##########
@@ -51,9 +51,11 @@ private[hive] class SparkGetFunctionsOperation(
override def runInternal(): Unit = {
// Do not change cmdStr. It's used for Hive auditing and authorization.
- val cmdStr = s"catalog : $catalogName, schemaPattern : $schemaName"
- val logMsg = s"Listing functions '$cmdStr, functionName : $functionName'"
- logInfo(log"${MDC(LogKeys.MESSAGE, logMsg)} with ${MDC(LogKeys.STATEMENT_ID, statementId)}")
+ val cmdMDC = log"catalog : ${MDC(LogKeys.CATALOG_NAME, catalogName)}, " +
Review Comment:
Let's make them more reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650264876
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -83,7 +83,7 @@ private[spark] class Executor(
extends Logging {
logInfo(log"Starting executor ID ${LogMDC(LogKeys.EXECUTOR_ID, executorId)}" +
- log" on host ${LogMDC(HOST_NAME, executorHostname)}")
+ log" on host ${LogMDC(HOST, executorHostname)}")
Review Comment:
Let's unify it as `HOST`, the general rule is
HOST: Only `host name`, not including `port`, eg: host_name
Port: Just the `port`, eg: 10240
HOST_PORT: includes both host name and port, eg: `host_name:10240`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650274581
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala:
##########
@@ -176,8 +176,7 @@ class StateStoreChangelogWriterV1(
} catch {
case e: Throwable =>
abort()
- logError(log"Fail to commit changelog file ${MDC(LogKeys.FILE_NAME, file)} " +
Review Comment:
Let's call it `PATH`, and make `e` as one of the parameters for `logError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650276697
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -869,7 +868,7 @@ private[spark] class ApplicationMaster(
}
} else {
logError(log"Application Master lost connection with driver! Shutting down. " +
- log"${MDC(LogKeys.REMOTE_ADDRESS, remoteAddress)}")
+ log"${MDC(LogKeys.HOST_PORT, remoteAddress)}")
Review Comment:
In the context of this code, it is called `HOST_PORT`, and we need to be consistent.
https://github.com/apache/spark/blob/e972daec30eb34e9352f37e9ac74db77a895d679/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala#L862-L873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48629] Migrate the residual code to structured logging framework [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650279373
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -527,10 +527,9 @@ private[spark] class ApplicationMaster(
userClassThread.join()
} catch {
case e: SparkException if e.getCause().isInstanceOf[TimeoutException] =>
- logError(
- log"""SparkContext did not initialize after waiting for
- |${MDC(LogKeys.TIMEOUT, totalWaitTime)} ms.
- | Please check earlier log output for errors. Failing the application.""".stripMargin)
+ logError(log"SparkContext did not initialize after waiting for " +
Review Comment:
Make the code format pretty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org