You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by gi...@git.apache.org on 2017/08/09 18:17:00 UTC

[GitHub] ctubbsii commented on a change in pull request #905: Add Accumulo API checks to checkstyle rules

ctubbsii commented on a change in pull request #905: Add Accumulo API checks to checkstyle rules
URL: https://github.com/apache/fluo/pull/905#discussion_r132264201
 
 

 ##########
 File path: src/main/resources/org/apache/fluo/resources/java-checkstyle.xml
 ##########
 @@ -170,5 +170,11 @@
       <message key="name.invalidPattern" value="Method name ''{0}'' must match pattern ''{1}''."/>
     </module>
     <module name="SingleLineJavadoc"/>
+    <module name="RegexpSinglelineJava">
 
 Review comment:
   I copied from the Fluo pom, but did not do any additional testing. I did, however, manually inspect to ensure I understood the expression and that it made sense, as a sanity check for what already existed. The only thing I changed was to make `\.` become `[.]`, because I think that construction is more clear (escapes are hard to reason about).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services