You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/20 20:10:33 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7811: ARROW-9534: [Rust] [DataFusion] Added support for lit to all supported rust types.

jorgecarleitao commented on a change in pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#discussion_r457663076



##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -378,9 +378,44 @@ pub fn col(name: &str) -> Expr {
     Expr::UnresolvedColumn(name.to_owned())
 }
 
-/// Create a literal string expression
-pub fn lit_str(str: &str) -> Expr {

Review comment:
       backward incompatible :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org