You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascopes (via GitHub)" <gi...@apache.org> on 2023/01/22 10:39:07 UTC
[GitHub] [maven-wrapper] ascopes opened a new pull request, #86: Fix bug in mvnw to handle \r in jvm.config correctly
ascopes opened a new pull request, #86:
URL: https://github.com/apache/maven-wrapper/pull/86
If Git checks out the jvm.config file with CRLF line endings, a condition can arise in Git Bash where \r does not get removed, resulting in -Xarg becoming '-Xarg\r' and breaking builds on Windows. This is reproducible in environments like GitHub Actions runners.
Assuming since this is a 2 character change that
this does not need a JIRA associated, under the
note of trivial changes.
ICLA already signed for previous contributions to
Surefire, and sent to the secretary.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #86: [MWRAPPER-95] Fix bug in mvnw to handle \r in jvm.config correctly
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-wrapper/pull/86#issuecomment-1435714976
Even when fix contains a few changed lines of code it is good to have a issue to report fixed bug in release notes 😄
So I have created a one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski merged pull request #86: [MWRAPPER-95] Fix bug in mvnw to handle \r in jvm.config correctly
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #86:
URL: https://github.com/apache/maven-wrapper/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org