You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by el...@apache.org on 2012/12/10 18:58:01 UTC
svn commit: r1419612 - in
/mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina:
core/session/DummySession.java
filter/executor/UnorderedThreadPoolExecutor.java
Author: elecharny
Date: Mon Dec 10 17:58:00 2012
New Revision: 1419612
URL: http://svn.apache.org/viewvc?rev=1419612&view=rev
Log:
Removed some Sonar warnings
Modified:
mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/core/session/DummySession.java
mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/filter/executor/UnorderedThreadPoolExecutor.java
Modified: mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/core/session/DummySession.java
URL: http://svn.apache.org/viewvc/mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/core/session/DummySession.java?rev=1419612&r1=1419611&r2=1419612&view=diff
==============================================================================
--- mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/core/session/DummySession.java (original)
+++ mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/core/session/DummySession.java Mon Dec 10 17:58:00 2012
@@ -77,7 +77,7 @@ public class DummySession extends Abstra
private final IoFilterChain filterChain = new DefaultIoFilterChain(this);
- private final IoProcessor<AbstractIoSession> processor;
+ private final IoProcessor<IoSession> processor;
private volatile IoHandler handler = new IoHandlerAdapter();
@@ -136,12 +136,12 @@ public class DummySession extends Abstra
}
});
- processor = new IoProcessor<AbstractIoSession>() {
- public void add(AbstractIoSession session) {
+ processor = new IoProcessor<IoSession>() {
+ public void add(IoSession session) {
// Do nothing
}
- public void flush(AbstractIoSession session) {
+ public void flush(IoSession session) {
DummySession s = (DummySession) session;
WriteRequest req = s.getWriteRequestQueue().poll(session);
@@ -165,7 +165,7 @@ public class DummySession extends Abstra
/**
* {@inheritDoc}
*/
- public void write(AbstractIoSession session, WriteRequest writeRequest) {
+ public void write(IoSession session, WriteRequest writeRequest) {
WriteRequestQueue writeRequestQueue = session.getWriteRequestQueue();
writeRequestQueue.offer(session, writeRequest);
@@ -175,13 +175,13 @@ public class DummySession extends Abstra
}
}
- public void remove(AbstractIoSession session) {
+ public void remove(IoSession session) {
if (!session.getCloseFuture().isClosed()) {
session.getFilterChain().fireSessionClosed();
}
}
- public void updateTrafficControl(AbstractIoSession session) {
+ public void updateTrafficControl(IoSession session) {
// Do nothing
}
@@ -291,7 +291,7 @@ public class DummySession extends Abstra
}
@Override
- public final IoProcessor<AbstractIoSession> getProcessor() {
+ public final IoProcessor<IoSession> getProcessor() {
return processor;
}
Modified: mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/filter/executor/UnorderedThreadPoolExecutor.java
URL: http://svn.apache.org/viewvc/mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/filter/executor/UnorderedThreadPoolExecutor.java?rev=1419612&r1=1419611&r2=1419612&view=diff
==============================================================================
--- mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/filter/executor/UnorderedThreadPoolExecutor.java (original)
+++ mina/mina/branches/2.0/mina-core/src/main/java/org/apache/mina/filter/executor/UnorderedThreadPoolExecutor.java Mon Dec 10 17:58:00 2012
@@ -267,6 +267,7 @@ public class UnorderedThreadPoolExecutor
IoEvent e = (IoEvent) task;
boolean offeredEvent = queueHandler.accept(this, e);
+
if (offeredEvent) {
getQueue().offer(e);
}