You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "hutcheb (via GitHub)" <gi...@apache.org> on 2023/02/11 05:48:50 UTC
[PR] Fix code gen concurrent modification (plc4x)
hutcheb opened a new pull request, #795:
URL: https://github.com/apache/plc4x/pull/795
Small fix for concurrent modification error when validating multiple mspecs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix code gen concurrent modification (plc4x)
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #795:
URL: https://github.com/apache/plc4x/pull/795#issuecomment-1428788329
Hopefully this should be a bit better,
https://github.com/apache/plc4x/commit/e369b2ea12e3b0a863cc3b0b28ede33d45dae18d
I found that when the setter.accept was being called it would occasionally modify the typedefinition list. Running through the consumers until we have nothing more to process seems to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix code gen concurrent modification (plc4x)
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #795:
URL: https://github.com/apache/plc4x/pull/795#issuecomment-1427979788
I agree, certainly need to revisit it. I should have some more time this week to get my head around how it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix code gen concurrent modification (plc4x)
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on PR #795:
URL: https://github.com/apache/plc4x/pull/795#issuecomment-1427930505
we might have other issues now like disconnected types etc... It might be better do synchronize and use the example from bacnet to understand why this is happening. So in the bacnet case you can reproduce it by moving up the statement how it was described in the deleted comment. For now we fixed the symptoms but not the root case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix code gen concurrent modification (plc4x)
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb merged PR #795:
URL: https://github.com/apache/plc4x/pull/795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix code gen concurrent modification (plc4x)
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #795:
URL: https://github.com/apache/plc4x/pull/795#issuecomment-1427743023
Bit of a hack, but it seems to work using a CopyOnWriteArray instead of linkedlist. Would be nice to figure out why a CoModificatioException is reaised otherwise.
Seems to have something to do with mspec types referencing other mspec types in other files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org