You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/02/13 16:07:48 UTC
[GitHub] MyXOF opened a new pull request #46: add sync function for jdbc
server to close and remove sleep fuction in ITs
MyXOF opened a new pull request #46: add sync function for jdbc server to close and remove sleep fuction in ITs
URL: https://github.com/apache/incubator-iotdb/pull/46
Before this commit, if you run `mvn clean verify` to trigger IT, you will see some logs like
```
ERROR [2019-02-13 11:42:31,571] [JDBC-ServerServiceImpl] org.apache.iotdb.db.service.JDBCService$JDBCServiceThread:181 - IoTDB: failed to start JDBC ServerService, because
org.apache.thrift.transport.TTransportException: Could not create ServerSocket on address 0.0.0.0/0.0.0.0:6667.
at org.apache.thrift.transport.TServerSocket.<init>(TServerSocket.java:109)
at org.apache.thrift.transport.TServerSocket.<init>(TServerSocket.java:91)
at org.apache.thrift.transport.TServerSocket.<init>(TServerSocket.java:83)
at org.apache.thrift.transport.TServerSocket.<init>(TServerSocket.java:76)
at org.apache.iotdb.db.service.JDBCService$JDBCServiceThread.run(JDBCService.java:171)
Caused by: java.net.BindException: Address already in use (Bind failed)
at java.net.PlainSocketImpl.socketBind(Native Method)
at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at org.apache.thrift.transport.TServerSocket.<init>(TServerSocket.java:106)
... 4 common frames omitted
```
This pull request solves problems about failing to create JDBC server.
Also, I remove `Thread.sleep(5000)` in our ITs, now JDBCService.close is a synchronized method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services