Re: svn commit: r1075548 - in /incubator/ace/trunk: ace-discovery-property/pom.xml ace-identification-property/pom.xml ace-obr-storage/pom.xml ace-repository-impl/pom.xml ace-webui-vaadin/osgi.bnd

[Jean-Baptiste Onofré <jb...@nanthrax.net>]

Hi Marcel,

as you can see, constants are defined in the private package statement, 
so not exposed to others bundles.
If you don't define it at least in the private package, felix 
maven-bundle-plugin doesn't include it in the bundle jar.
As this package is used in the integration tests, it should be embedded 
in the generated bundle jar.

For the build, I'm cleaning my local maven repo and fix it.

Regards
JB

On 02/28/2011 11:40 PM, Marcel Offermans wrote:
> On Feb 28, 2011, at 22:41 ,<jb...@apache.org>  wrote:
>
>> Author: jbonofre
>> Date: Mon Feb 28 21:41:41 2011
>> New Revision: 1075548
>
>> Modified: incubator/ace/trunk/ace-discovery-property/pom.xml
>> URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-discovery-property/pom.xml?rev=1075548&r1=1075547&r2=1075548&view=diff
>> ==============================================================================
>> --- incubator/ace/trunk/ace-discovery-property/pom.xml (original)
>> +++ incubator/ace/trunk/ace-discovery-property/pom.xml Mon Feb 28 21:41:41 2011
>> @@ -40,7 +40,8 @@
>>              *
>>          </import.package>
>>          <private.package>
>> -            org.apache.ace.discovery.property
>> +            org.apache.ace.discovery.property,
>> +            org.apache.ace.discovery.property.constants
>>          </private.package>
>>          <bundle.activator>org.apache.ace.discovery.property.Activator</bundle.activator>
>>      </properties>
>
> Why are you adding the .constants package? It only contains constants that are applied by the Java compiler. They are not needed at all at runtime, which is why we did not include them in the first place.
>
> Also, I regret to have to say the the build is still broken. That means I basically could not take a look at the problematic integration test that kept hanging. I would really appreciate it if you would fix the build on the next commit, or roll everything back to a compiling state and prepare an update that works completely.
>
> Greetings, Marcel
>