You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/02 02:48:24 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011099572


##########
arch/arm/src/cxd56xx/cxd56_hostif.c:
##########
@@ -379,8 +382,6 @@ static int hif_initialize(struct hostif_buff_s *buffer)
 
   DEBUGASSERT(buffer);
 
-  memset(drv, 0, sizeof(struct cxd56_hifdrv_s));
-

Review Comment:
   No, it's relate because memset will destroy the initial value at the definition place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org