You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/26 17:15:31 UTC

[GitHub] [dubbo-go-samples] PhilYue opened a new pull request #186: Ftr: test shopping for 1.5

PhilYue opened a new pull request #186:
URL: https://github.com/apache/dubbo-go-samples/pull/186


   # test shopping-order
   - minor version refactoring for running easily
   - manual test passed
   
   TODO: test by integration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #186: Ftr: test shopping for 1.5

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #186:
URL: https://github.com/apache/dubbo-go-samples/pull/186#discussion_r679318596



##########
File path: shopping-order/go-server-product/cmd/server.go
##########
@@ -20,6 +20,7 @@ package main
 import (
 	"database/sql"
 	"fmt"
+	"github.com/apache/dubbo-go-samples/shopping-order/go-server-product/pkg"

Review comment:
       pls move  it out




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] AlexStocks merged pull request #186: Ftr: test shopping for 1.5

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #186:
URL: https://github.com/apache/dubbo-go-samples/pull/186


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org