You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by shirolk <gi...@git.apache.org> on 2015/01/26 02:17:40 UTC
[GitHub] stratos pull request: Validate removal of cartridges cartridgegrou...
GitHub user shirolk opened a pull request:
https://github.com/apache/stratos/pull/187
Validate removal of cartridges cartridgegroups
The purpose of the pull request is to incorporate validation when either a cartridge or cartridge group is removed - essentially these can only be remove if they are not included in either cartridge groups or applications.
This fixes STRATOS-1092
Performed the following testing on this PR.
1. add cartridge - remove cartridge = OK
2. add cartridge - add application with cartridge - remove cartridge = OK
3. add cartridge - add service group - remove cartridge = OK
4. add cartridge - add service group - add application with service group and cartridge - remove service group - remove cartirdge = OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shirolk/stratos validate-removal-cartridges-cartridgegroups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 74b9b22e92d7761014cea05d60e91d85f8eda697
Author: Shiro <sh...@wso2.com>
Date: 2015-01-23T11:44:49Z
Added functionality to do validation before cartridge and cartridgeGroup removal
commit b5075fb64b68d94f9b8d634750208b2435a8e7cb
Author: Shiro <sh...@wso2.com>
Date: 2015-01-23T15:18:01Z
Fixed a few issues in validation proceedures
commit cae97c3860dde90cb88014ea22c695210b60799f
Author: Shiro <sh...@wso2.com>
Date: 2015-01-23T11:44:49Z
Added functionality to do validation before cartridge and cartridgeGroup removal
commit fa0292b3d4b5ad02eb36834c59e5ef62c0e14144
Author: Shiro <sh...@wso2.com>
Date: 2015-01-23T15:18:01Z
Fixed a few issues in validation proceedures
commit 46ac684ea6ddc742c4ff9b25cc27d6f0a7fe559e
Author: Shiro <sh...@wso2.com>
Date: 2015-01-26T01:01:09Z
Fixed merge conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Validate removal of cartridges cartridgegrou...
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:
https://github.com/apache/stratos/pull/187#issuecomment-71417724
Thanks Shiro for your contribution! Appreciate it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Validate removal of cartridges cartridgegrou...
Posted by shirolk <gi...@git.apache.org>.
Github user shirolk commented on the pull request:
https://github.com/apache/stratos/pull/187#issuecomment-71418604
Thanks you for merging !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Validate removal of cartridges cartridgegrou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/stratos/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---