You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/17 06:24:56 UTC

[GitHub] wu-sheng opened a new pull request #1086: Provide new trace query protocol

wu-sheng opened a new pull request #1086: Provide new trace query protocol
URL: https://github.com/apache/incubator-skywalking/pull/1086
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   
   ### New feature or improvement
   - Describe the details and related test reports.
   Based on I and @hanahmily 's discussion, we decided to refactor the whole trace query page. For supporting that, backend should open the Segment data structure to frontend, in order to give front end more freedom to focus on visualization.
   
   So, in this pull request, I will submit the new return value of trace query service. Please review the protocol from here:
   ```
   type Trace {
     segments: [Segment!]!
     # Segment IDs in refs may not exist in #segments list, because MQ batch process trace segments didn't share the same ID.
     # UI should add visual node for non-exist segment.
     refs: [SegmentRef!]!
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services