You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2009/07/07 11:18:14 UTC
[jira] Created: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
---------------------------------------------------------------------------------------
Key: SLING-1036
URL: https://issues.apache.org/jira/browse/SLING-1036
Project: Sling
Issue Type: Bug
Components: Launchpad
Reporter: Bertrand Delacretaz
With mvn 2.0.10 the launchpad/base build fails with
"Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728106#action_12728106 ]
Carsten Ziegeler commented on SLING-1036:
-----------------------------------------
Hmm the problematic file is the source jar :)
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-1036.
--------------------------------------
Resolution: Fixed
Fix Version/s: Launchpad Base 2.0.6
Changed the project descriptor to use the default location of generated remote resources for the web application and removed the local reconfiguration of the remote resources plugin in Rev. 791843.
This fixes the issue with Maven 2.0.9. Closing this issue when Hudson reports success, too.
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.0.6
>
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-1036:
----------------------------------------
Assignee: Felix Meschberger
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728003#action_12728003 ]
Carsten Ziegeler commented on SLING-1036:
-----------------------------------------
The problem seems to be caused by the remote-resources plugin; if that is removed from the config, the source jar contains the files again.
One difference between 2.0.x and 2.1 is the handling of the default configuration for plugins:
while this:
<plugin>
<!-- overwrite the default location -->
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<outputDirectory>${remote.res.tmp}</outputDirectory>
</configuration>
</plugin>
applies the config to the default phase (process) in 2.1, it doesn't do this for 2.0.x
I've changed this to:
<plugin>
<!-- overwrite the default location -->
<artifactId>maven-remote-resources-plugin</artifactId>
<executions>
<execution>
<goals><goal>process</goal></goals>
<configuration>
<outputDirectory>${remote.res.tmp}</outputDirectory>
</configuration>
</execution></executions>
</plugin>
and the output directory configuration seems to be handled correctly in 2.0.x
Although this doesn't solve the problem :(
Easy fix would be to set the minimum mvn version to 2.1 (or 2.2?) - but I'm not sure if we want to go this way.
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728105#action_12728105 ]
Felix Meschberger commented on SLING-1036:
------------------------------------------
Another option is to just hard-code the default location into the war plugin ....
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728107#action_12728107 ]
Carsten Ziegeler commented on SLING-1036:
-----------------------------------------
Ok, got it - yes if that works
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-1036.
------------------------------------
Hudson builds again. So this can be closed.
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.0.6
>
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728002#action_12728002 ]
Bertrand Delacretaz commented on SLING-1036:
--------------------------------------------
Note that explicitely calling
mvn clean source:jar org.codehaus.mojo:ianal-maven-plugin:verify-legal-files
works with 2.0.10, and creates a correct -sources.jar
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1036) launchpad/base build fails with mvn
2.0.10, "Artifact does not contain any legal files"
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728108#action_12728108 ]
Felix Meschberger commented on SLING-1036:
------------------------------------------
Ok, taking over to check it
> launchpad/base build fails with mvn 2.0.10, "Artifact does not contain any legal files"
> ---------------------------------------------------------------------------------------
>
> Key: SLING-1036
> URL: https://issues.apache.org/jira/browse/SLING-1036
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Bertrand Delacretaz
> Assignee: Felix Meschberger
>
> With mvn 2.0.10 the launchpad/base build fails with
> "Artifact does not contain any legal files: org.apache.sling.launchpad.base-2.0.5-SNAPSHOT-sources.jar"
> which is correct as the jar file does not contain the LICENSE and NOTICE files in this case.
> Build works with mvn 2.1.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.