You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wangchdo (via GitHub)" <gi...@apache.org> on 2025/11/19 13:14:39 UTC
[PR] CMake: Enable Kconfig generation for external directories [nuttx]
wangchdo opened a new pull request, #17350:
URL: https://github.com/apache/nuttx/pull/17350
## Summary
Currently, nuttx_generate_kconfig() can only parse subdirectories under apps/.
This patch extends its capability to also parse external directories referenced from the apps tree.
## Impact
Add new capabilites for nuttx_generate_kconfig(), no impact to any nuttx functions
## Testing
1. add tmp directory:
```
├── nuttx-apps
└── tmp
├── CMakeLists.txt
└── Kconfig
```
2. Update nuttx-apps/CMakeLists.txt:
nuttx_generate_kconfig(EXTERNAL_DIRECTORIES ${CMAKE_CURRENT_LIST_DIR}/../tmp)
3. Kconfig in tmp directory is included:
```
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_audioutils_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_benchmarks_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_boot_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_canutils_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_crypto_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_examples_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_fsutils_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_games_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_graphics_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_industry_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_interpreters_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_logging_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_lte_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_math_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_mlearning_Kconfig"
source "/home/lixiang/repos/nuttxspace/nuttx-apps/modbus/Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_netutils_Kconfig"
source "/home/lixiang/repos/nuttxspace/nuttx-apps/nshlib/Kconfig"
source "/home/lixiang/repos/nuttxspace/nuttx-apps/platform/Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_sdr_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_system_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_tee_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_testing_Kconfig"
source "/home/lixiang/repos/nuttxspace/nuttx-apps/tools/Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_videoutils_Kconfig"
source "/home/lixiang/repos/nuttxspace/output/nuttx-apps/_home_lixiang_repos_nuttxspace_nuttx-apps_wireless_Kconfig"
source "/home/lixiang/repos/nuttxspace/nuttx-apps/../tmp/Kconfig"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: Enable Kconfig generation for external directories [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #17350:
URL: https://github.com/apache/nuttx/pull/17350#issuecomment-3553352482
> Is it possible to add these features to Make?
Makefile already supports it, but AFAIK it requires that the directory be added inside nutt-apps/external/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: Enable Kconfig generation for external directories [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on code in PR #17350:
URL: https://github.com/apache/nuttx/pull/17350#discussion_r2542127039
##########
cmake/nuttx_kconfig.cmake:
##########
@@ -117,6 +117,8 @@ function(nuttx_generate_kconfig)
nuttx_generate_kconfig
ONE_VALUE
MENUDESC
+ MULTI_VALUE
+ EXTERNAL_DIRECTORIES
Review Comment:
Will changing this signature require updates to the function call elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: Enable Kconfig generation for external directories [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #17350:
URL: https://github.com/apache/nuttx/pull/17350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: Enable Kconfig generation for external directories [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #17350:
URL: https://github.com/apache/nuttx/pull/17350#issuecomment-3552848415
Is it possible to add these features to Make?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: Enable Kconfig generation for external directories [nuttx]
Posted by "wangchdo (via GitHub)" <gi...@apache.org>.
wangchdo commented on code in PR #17350:
URL: https://github.com/apache/nuttx/pull/17350#discussion_r2543896011
##########
cmake/nuttx_kconfig.cmake:
##########
@@ -117,6 +117,8 @@ function(nuttx_generate_kconfig)
nuttx_generate_kconfig
ONE_VALUE
MENUDESC
+ MULTI_VALUE
+ EXTERNAL_DIRECTORIES
Review Comment:
No, this new para is optional, it is only needed when users want to add external directories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org