You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/04 04:41:05 UTC
Review Request 55162: Stout: Added style fixes and some useful error
messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Repository: mesos
Description
-------
Stout: Added style fixes and some useful error messages.
Diffs
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/#review164379
-----------------------------------------------------------
These changes won't be necessary with the `WindowsLauncher` patches.
- Andrew Schwartzmeyer
On Jan. 29, 2017, 7:20 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55162/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2017, 7:20 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout: Added style fixes and some useful error messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
> 3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
>
> Diff: https://reviews.apache.org/r/55162/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 7:20 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Changes
-------
Rearrange dependency.
Repository: mesos
Description
-------
Stout: Added style fixes and some useful error messages.
Diffs
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/#review160693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55022, 55023, 55024, 55025, 55026, 55028, 55029, 55030, 55037, 55038, 55039, 55040, 55161, 55162]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 6, 2017, 12:03 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55162/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 12:03 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout: Added style fixes and some useful error messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
> 3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
>
> Diff: https://reviews.apache.org/r/55162/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/
-----------------------------------------------------------
(Updated Jan. 6, 2017, 12:03 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Changes
-------
Added forgotten semicolon. :(
Repository: mesos
Description
-------
Stout: Added style fixes and some useful error messages.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 11:27 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Repository: mesos
Description
-------
Stout: Added style fixes and some useful error messages.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55162: Stout: Added style fixes and some useful
error messages.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55162/#review160627
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55022, 55023, 55024, 55025, 55026, 55028, 55029, 55030, 55037, 55038, 55039, 55040, 55161, 55162]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 4, 2017, 4:41 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55162/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 4:41 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout: Added style fixes and some useful error messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
> 3rdparty/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902
>
> Diff: https://reviews.apache.org/r/55162/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>