You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2010/12/23 22:07:38 UTC
Re: New serious bug, not Ready for a 2.0.4 release
Am 17.12.10 20:51, schrieb Rainer Schöpf:
> On Wed, 15 Dec 2010 at 11:34 +0100, Florent André wrote:
>
>> Hi,
>>
>> On 12/14/2010 07:55 AM, Rainer Schöpf wrote:
>>> On Mon, 13 Dec 2010, Florent André wrote:
>>>
>>> [...]
>>>
>>>> Yep, $ ./build.sh test
>> ...
>>>> Running org.apache.lenya.cms.export.ImportTest Testsuite:
>>>> org.apache.lenya.cms.export.ImportTest Tests run: 1, Failures:
>>>> 1, Errors: 0, Time elapsed: 1.913 sec Tests run: 1, Failures:
>>>> 1, Errors: 0, Time elapsed: 1.913 sec Testcase: testImport took
>>>> 1.607 sec FAILED
>>>
>>> Exactly. That failure worries me.
>>
>> Ok solve in Committed revision 1049475.
>
> Atually no, it reappears in LinkTest. Problem is that links are not
> rewritten to lenya-document: form during import.
>
> This is a new bug introduced by the change described here:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=47621
>
> When I revert the change, links are rewritten correctly.
That should be fixed now. Not in a very nice way, though: The link
converter checks the current session first, and if a URI is not
converted, it tries the new session, just to be sure. A cleaner way
would probably be to re-set the source editor session before saving, but
this is not so easy I think.
-- Andreas
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: New serious bug, not Ready for a 2.0.4 release
Posted by Rainer Schöpf <ra...@gmx.net>.
Hi Florent,
> Do you think it's a blocker for the 2.0.4 release ?
Nono, not at all.
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: New serious bug, not Ready for a 2.0.4 release
Posted by florent andré <fl...@4sengines.com>.
On 12/24/2010 03:31 PM, Rainer Schöpf wrote:
> On Thu, 23 Dec 2010 at 22:07 +0100, Andreas Hartmann wrote:
>
> > Am 17.12.10 20:51, schrieb Rainer Schöpf:
> > > On Wed, 15 Dec 2010 at 11:34 +0100, Florent André wrote:
> > >
....
> > >
> > > https://issues.apache.org/bugzilla/show_bug.cgi?id=47621
> > >
> > > When I revert the change, links are rewritten correctly.
> >
> > That should be fixed now. Not in a very nice way, though: The link
> > converter checks the current session first, and if a URI is not
> > converted, it tries the new session, just to be sure. A cleaner way would
> > probably be to re-set the source editor session before saving, but this is
> > not so easy I think.
>
> Wouldn't it be possible to roll-forward into the editor session all changes made
> to the sitetree while editing the document?
No idea on it for me...
Do you think it's a blocker for the 2.0.4 release ?
>
> Anyway, all tests are looking good now.
Yes, I just have a try now, and all is OK. Thanks to all of you for
solving this issues !
++
>
> Seasons greeting to all of you!
>
> Rainer
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: New serious bug, not Ready for a 2.0.4 release
Posted by Rainer Schöpf <ra...@gmx.net>.
On Thu, 23 Dec 2010 at 22:07 +0100, Andreas Hartmann wrote:
> Am 17.12.10 20:51, schrieb Rainer Schöpf:
> > On Wed, 15 Dec 2010 at 11:34 +0100, Florent André wrote:
> >
> > > Hi,
> > >
> > > On 12/14/2010 07:55 AM, Rainer Schöpf wrote:
> > > > On Mon, 13 Dec 2010, Florent André wrote:
> > > >
> > > > [...]
> > > >
> > > > > Yep, $ ./build.sh test
> > > ...
> > > > > Running org.apache.lenya.cms.export.ImportTest Testsuite:
> > > > > org.apache.lenya.cms.export.ImportTest Tests run: 1, Failures:
> > > > > 1, Errors: 0, Time elapsed: 1.913 sec Tests run: 1, Failures:
> > > > > 1, Errors: 0, Time elapsed: 1.913 sec Testcase: testImport took
> > > > > 1.607 sec FAILED
> > > >
> > > > Exactly. That failure worries me.
> > >
> > > Ok solve in Committed revision 1049475.
> >
> > Atually no, it reappears in LinkTest. Problem is that links are not
> > rewritten to lenya-document: form during import.
> >
> > This is a new bug introduced by the change described here:
> >
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=47621
> >
> > When I revert the change, links are rewritten correctly.
>
> That should be fixed now. Not in a very nice way, though: The link
> converter checks the current session first, and if a URI is not
> converted, it tries the new session, just to be sure. A cleaner way would
> probably be to re-set the source editor session before saving, but this is
> not so easy I think.
Wouldn't it be possible to roll-forward into the editor session all changes made
to the sitetree while editing the document?
Anyway, all tests are looking good now.
Seasons greeting to all of you!
Rainer