[GitHub] [incubator-dubbo] scxwhite opened pull request #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

Be sure to close thread pool when not in use

## Brief changelog

Memory leak

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on issue #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

> Why u change all of this class?
> Pls revert it. otherwise, LGTM

I am so sorry. No experience to submit pr.please see new pr.[#3255](https://github.com/apache/incubator-dubbo/pull/3255)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #3207: Be sure to close thread pool when not in use

["carryxyh (GitHub)" <gi...@apache.org>]

Why u change all of this class?
Pls revert it. otherwise, LGTM

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on pull request #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

Use the shutdown method instead of the shutdownnow method. Tasks previously submitted are executed, even in queues

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3207: Be sure to close thread pool when not in use

["carryxyh (GitHub)" <gi...@apache.org>]

Don't use import *

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on pull request #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

Use the shutdown method instead of the shutdownnow method. Tasks previously submitted are executed, even in queues

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite closed pull request #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

[ pull request closed by scxwhite ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on issue #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

> Why u change all of this class?
> Pls revert it. otherwise, LGTM

oh my god ! i use github deal conflict，i revert it.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on issue #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

> Why u change all of this class?
> Pls revert it. otherwise, LGTM



[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite commented on issue #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

I think I should deal with it. It still shows so much line after revert. I will submit a new PR

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3207: Be sure to close thread pool when not in use

["carryxyh (GitHub)" <gi...@apache.org>]

How do we determine that the dump work has been completed?
The best practice should be to close the thread pool after the dump ends.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] scxwhite closed pull request #3207: Be sure to close thread pool when not in use

["scxwhite (GitHub)" <gi...@apache.org>]

[ pull request closed by scxwhite ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3207 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org