You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Robert Bradshaw <ro...@google.com> on 2020/07/02 18:04:00 UTC
Re: Request for Java PR review
Thanks for your contributions. For future reference, picking a reviewer by
adding a comment R: @some-username (e.g. based on the source code history
of the files in question) or in the suggestions for reviewers on the right
hand side can help get things moving quicker.
On Tue, Jun 23, 2020 at 5:44 PM Chamikara Jayalath <ch...@google.com>
wrote:
> Thanks. I'm taking a look.
>
> On Tue, Jun 23, 2020 at 3:07 AM Niel Markwick <ni...@google.com> wrote:
>
>> Hey devs...
>>
>> I have 3 PRs sitting waiting for a code review to fix potential bugs (and
>> improve memory use) in SpannerIO. 2 small, and one quite large -- I would
>> really like these to be in 2.23...
>>
>> https://github.com/apache/beam/pulls/nielm
>>
>> Would someone be willing to have a look?
>>
>> Thanks!
>>
>> --
>> <https://cloud.google.com>
>> * • **Niel Markwick*
>> * • *Cloud Solutions Architect <https://cloud.google.com/docs/tutorials>
>> * • *Google Belgium
>> * • *nielm@google.com
>> * • *+32 2 894 6771
>>
>>
>> Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: 0878.065.378
>>
>> If you have received this communication by mistake, please don't forward
>> it to anyone else (it may contain confidential or privileged information),
>> please erase all copies of it, including all attachments, and please let
>> the sender know it went to the wrong person. Thanks
>>
>
Re: Request for Java PR review
Posted by Robert Bradshaw <ro...@google.com>.
Yeah, the fact that not everyone can see suggested reviewers is annoying.
Mostly I just wanted to call out that if you have a PR and haven't gotten
feedback on it, it's totally kosher to as someone specifically to be a
reviewer, and this can often get the ball rolling quicker. (Pinging the
list is fine as well, especially when you're starting out.)
On Wed, Jul 8, 2020 at 4:59 PM Rui Wang <ru...@google.com> wrote:
> I didn't hear that has been changed so assume it's still only committers
> that can see suggested reviewers, thus picking up someone based on the
> source code history could be the feasible solution for non-committers.
>
> An improvement though could be when picking up someone from the history,
> you can check [1] to pick up a committer from that history. So that
> committer can request reviewers on the right hand side.
>
>
> [1]: https://projects.apache.org/committee.html?beam
>
> -Rui
>
> On Tue, Jul 7, 2020 at 2:42 PM Brian Hulette <bh...@google.com> wrote:
>
>> One thing that's a bit annoying is non-committers can't see the
>> suggestions on the right-hand side, and they also don't have permission to
>> set a reviewer. At least that was the case before I was a committer, I
>> can't confirm if it's still true.
>>
>> On Thu, Jul 2, 2020 at 11:04 AM Robert Bradshaw <ro...@google.com>
>> wrote:
>>
>>> Thanks for your contributions. For future reference, picking a reviewer
>>> by adding a comment R: @some-username (e.g. based on the source code
>>> history of the files in question) or in the suggestions for reviewers on
>>> the right hand side can help get things moving quicker.
>>>
>>> On Tue, Jun 23, 2020 at 5:44 PM Chamikara Jayalath <ch...@google.com>
>>> wrote:
>>>
>>>> Thanks. I'm taking a look.
>>>>
>>>> On Tue, Jun 23, 2020 at 3:07 AM Niel Markwick <ni...@google.com> wrote:
>>>>
>>>>> Hey devs...
>>>>>
>>>>> I have 3 PRs sitting waiting for a code review to fix potential bugs
>>>>> (and improve memory use) in SpannerIO. 2 small, and one quite large -- I
>>>>> would really like these to be in 2.23...
>>>>>
>>>>> https://github.com/apache/beam/pulls/nielm
>>>>>
>>>>> Would someone be willing to have a look?
>>>>>
>>>>> Thanks!
>>>>>
>>>>> --
>>>>> <https://cloud.google.com>
>>>>> * • **Niel Markwick*
>>>>> * • *Cloud Solutions Architect
>>>>> <https://cloud.google.com/docs/tutorials>
>>>>> * • *Google Belgium
>>>>> * • *nielm@google.com
>>>>> * • *+32 2 894 6771
>>>>>
>>>>>
>>>>> Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: 0878.065.378
>>>>>
>>>>> If you have received this communication by mistake, please don't
>>>>> forward it to anyone else (it may contain confidential or privileged
>>>>> information), please erase all copies of it, including all attachments, and
>>>>> please let the sender know it went to the wrong person. Thanks
>>>>>
>>>>
Re: Request for Java PR review
Posted by Rui Wang <ru...@google.com>.
I didn't hear that has been changed so assume it's still only committers
that can see suggested reviewers, thus picking up someone based on the
source code history could be the feasible solution for non-committers.
An improvement though could be when picking up someone from the history,
you can check [1] to pick up a committer from that history. So that
committer can request reviewers on the right hand side.
[1]: https://projects.apache.org/committee.html?beam
-Rui
On Tue, Jul 7, 2020 at 2:42 PM Brian Hulette <bh...@google.com> wrote:
> One thing that's a bit annoying is non-committers can't see the
> suggestions on the right-hand side, and they also don't have permission to
> set a reviewer. At least that was the case before I was a committer, I
> can't confirm if it's still true.
>
> On Thu, Jul 2, 2020 at 11:04 AM Robert Bradshaw <ro...@google.com>
> wrote:
>
>> Thanks for your contributions. For future reference, picking a reviewer
>> by adding a comment R: @some-username (e.g. based on the source code
>> history of the files in question) or in the suggestions for reviewers on
>> the right hand side can help get things moving quicker.
>>
>> On Tue, Jun 23, 2020 at 5:44 PM Chamikara Jayalath <ch...@google.com>
>> wrote:
>>
>>> Thanks. I'm taking a look.
>>>
>>> On Tue, Jun 23, 2020 at 3:07 AM Niel Markwick <ni...@google.com> wrote:
>>>
>>>> Hey devs...
>>>>
>>>> I have 3 PRs sitting waiting for a code review to fix potential bugs
>>>> (and improve memory use) in SpannerIO. 2 small, and one quite large -- I
>>>> would really like these to be in 2.23...
>>>>
>>>> https://github.com/apache/beam/pulls/nielm
>>>>
>>>> Would someone be willing to have a look?
>>>>
>>>> Thanks!
>>>>
>>>> --
>>>> <https://cloud.google.com>
>>>> * • **Niel Markwick*
>>>> * • *Cloud Solutions Architect
>>>> <https://cloud.google.com/docs/tutorials>
>>>> * • *Google Belgium
>>>> * • *nielm@google.com
>>>> * • *+32 2 894 6771
>>>>
>>>>
>>>> Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: 0878.065.378
>>>>
>>>> If you have received this communication by mistake, please don't
>>>> forward it to anyone else (it may contain confidential or privileged
>>>> information), please erase all copies of it, including all attachments, and
>>>> please let the sender know it went to the wrong person. Thanks
>>>>
>>>
Re: Request for Java PR review
Posted by Brian Hulette <bh...@google.com>.
One thing that's a bit annoying is non-committers can't see the suggestions
on the right-hand side, and they also don't have permission to set a
reviewer. At least that was the case before I was a committer, I can't
confirm if it's still true.
On Thu, Jul 2, 2020 at 11:04 AM Robert Bradshaw <ro...@google.com> wrote:
> Thanks for your contributions. For future reference, picking a reviewer by
> adding a comment R: @some-username (e.g. based on the source code history
> of the files in question) or in the suggestions for reviewers on the right
> hand side can help get things moving quicker.
>
> On Tue, Jun 23, 2020 at 5:44 PM Chamikara Jayalath <ch...@google.com>
> wrote:
>
>> Thanks. I'm taking a look.
>>
>> On Tue, Jun 23, 2020 at 3:07 AM Niel Markwick <ni...@google.com> wrote:
>>
>>> Hey devs...
>>>
>>> I have 3 PRs sitting waiting for a code review to fix potential bugs
>>> (and improve memory use) in SpannerIO. 2 small, and one quite large -- I
>>> would really like these to be in 2.23...
>>>
>>> https://github.com/apache/beam/pulls/nielm
>>>
>>> Would someone be willing to have a look?
>>>
>>> Thanks!
>>>
>>> --
>>> <https://cloud.google.com>
>>> * • **Niel Markwick*
>>> * • *Cloud Solutions Architect
>>> <https://cloud.google.com/docs/tutorials>
>>> * • *Google Belgium
>>> * • *nielm@google.com
>>> * • *+32 2 894 6771
>>>
>>>
>>> Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: 0878.065.378
>>>
>>> If you have received this communication by mistake, please don't forward
>>> it to anyone else (it may contain confidential or privileged information),
>>> please erase all copies of it, including all attachments, and please let
>>> the sender know it went to the wrong person. Thanks
>>>
>>