You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2023/11/17 14:47:17 UTC
[PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
brbzull0 opened a new pull request, #10811:
URL: https://github.com/apache/trafficserver/pull/10811
Moving the removed ATS backtrace logs from traffic_manager to traffic_crashlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "randall (via GitHub)" <gi...@apache.org>.
randall commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1398013125
##########
src/traffic_crashlog/backtrace.cc:
##########
@@ -0,0 +1,178 @@
+#include "tscore/ink_config.h"
Review Comment:
it caught it, but didn't fail the build: https://ci.trafficserver.apache.org/job/Github_Builds/job/rat/3830/console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1399158484
##########
src/traffic_crashlog/CMakeLists.txt:
##########
@@ -15,8 +15,8 @@
#
#######################
-add_executable(traffic_crashlog procinfo.cc traffic_crashlog.cc)
+add_executable(traffic_crashlog procinfo.cc backtrace.cc traffic_crashlog.cc)
-target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore)
+target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore unwind::unwind)
Review Comment:
It should work now as.
Thanks @cmcfarlen for collaborating with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#issuecomment-1819736476
```
-- TS_USE_REMOTE_UNWINDING: FALSE (AUTO) (hint: add -DENABLE_UNWIND=ON to require)
..
--
-- Configuring done
CMake Error at src/traffic_crashlog/CMakeLists.txt:18 (add_executable):
Target "traffic_crashlog" links to target "unwind::unwind" but the target
was not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
```
seems that we try to link with the unwind namespace eventhough is not eabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1397525394
##########
src/traffic_crashlog/backtrace.cc:
##########
@@ -0,0 +1,178 @@
+#include "tscore/ink_config.h"
Review Comment:
We'll need our Apache license preface added to this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1397725311
##########
src/traffic_crashlog/backtrace.cc:
##########
@@ -0,0 +1,178 @@
+#include "tscore/ink_config.h"
Review Comment:
weird that the `RAT` ci didn't fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#issuecomment-1829472262
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#issuecomment-1833519239
[approve ci rat]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#issuecomment-1821136010
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1400780073
##########
src/traffic_crashlog/backtrace.cc:
##########
@@ -0,0 +1,178 @@
+#include "tscore/ink_config.h"
Review Comment:
Thank you for the heads up, @randall and @brbzull0. When I added cmake support to CI, I assumed that the rat target would have a non-zero return if the check failed. I updated the pipeline to check the output and fail if there were not 0 errors (as we did with autotools).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1397430036
##########
src/traffic_crashlog/CMakeLists.txt:
##########
@@ -15,8 +15,8 @@
#
#######################
-add_executable(traffic_crashlog procinfo.cc traffic_crashlog.cc)
+add_executable(traffic_crashlog procinfo.cc backtrace.cc traffic_crashlog.cc)
-target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore)
+target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore unwind::unwind)
Review Comment:
This wont work, I had to manually add `unwind-ptrace unwind-generic` on my ubuntu 20.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #10811:
URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1397430036
##########
src/traffic_crashlog/CMakeLists.txt:
##########
@@ -15,8 +15,8 @@
#
#######################
-add_executable(traffic_crashlog procinfo.cc traffic_crashlog.cc)
+add_executable(traffic_crashlog procinfo.cc backtrace.cc traffic_crashlog.cc)
-target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore)
+target_link_libraries(traffic_crashlog PRIVATE ts::inkevent ts::records ts::tscore ts::tsapicore unwind::unwind)
Review Comment:
~~This wont work, I had to manually add `unwind-ptrace unwind-generic` on my ubuntu 20.04.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org