You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/06 17:57:50 UTC

[GitHub] [beam] sclukas77 commented on a change in pull request #12090: [BEAM-10336,BEAM-10337] Add SchemaIO abstraction and implement for PubSub

sclukas77 commented on a change in pull request #12090:
URL: https://github.com/apache/beam/pull/12090#discussion_r450389176



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubIOJsonTable.java
##########
@@ -122,14 +115,14 @@
 @Experimental
 class PubsubIOJsonTable extends BaseBeamTable implements Serializable {

Review comment:
       Making the provider and table classes generic is being worked on in another branch. The renaming corrections will be part of a separate PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org