You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "devCod3r (via GitHub)" <gi...@apache.org> on 2023/04/15 11:46:47 UTC
[GitHub] [eventmesh] devCod3r opened a new pull request, #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
devCod3r opened a new pull request, #3694:
URL: https://github.com/apache/eventmesh/pull/3694
Fixes #3416
### Motivation
*Because Double Brace Initialization (DBI) creates an anonymous class with a reference to the instance of the owning object, its use can lead to memory leaks if the anonymous inner class is returned and held by other objects. Even when there’s no leak, DBI is so obscure that it’s bound to confuse most maintainers.*
*Fixes the above mentioned issue.*
Issue #3416
### Modifications
*Modified the initialization of localClients instance on line 391,451.*
### Documentation
- Does this pull request introduce a new feature?
- Ans: no
- If a feature is not applicable for documentation, explain why?
- Ans: Only changed the method of initialization of an instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3694:
URL: https://github.com/apache/eventmesh/pull/3694#issuecomment-1502837171
Please check checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] devCod3r closed pull request #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
Posted by "devCod3r (via GitHub)" <gi...@apache.org>.
devCod3r closed pull request #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
URL: https://github.com/apache/eventmesh/pull/3694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] devCod3r closed pull request #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
Posted by "devCod3r (via GitHub)" <gi...@apache.org>.
devCod3r closed pull request #3694: [ISSUE #3416] Used another way to initialize localClients instance [HttpClientGroupMapping]
URL: https://github.com/apache/eventmesh/pull/3694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org