You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/12 12:36:54 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #36524: [WIP][SPARK-39165][SQL] Replace `sys.error` by `IllegalStateException`
MaxGekk opened a new pull request, #36524:
URL: https://github.com/apache/spark/pull/36524
### What changes were proposed in this pull request?
Replace all invokes of `sys.error()` by throwing of `IllegalStateException` in the `sql` namespace.
### Why are the changes needed?
In the context of wrapping all internal errors like asserts/illegal state exceptions (see https://github.com/apache/spark/pull/36500), it is impossible to distinguish `RuntimeException` of `sys.error()` from Spark's exceptions like `SparkRuntimeException`. The last one can be propagated to the user space but `sys.error` exceptions shouldn't be visible to users in regular cases.
### Does this PR introduce _any_ user-facing change?
No, shouldn't. sys.error shouldn't propagate exception to user space in regular cases.
### How was this patch tested?
By running the existing test suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36524: [SPARK-39165][SQL] Replace `sys.error` by `IllegalStateException`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36524: [SPARK-39165][SQL] Replace `sys.error` by `IllegalStateException`
URL: https://github.com/apache/spark/pull/36524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36524: [SPARK-39165][SQL] Replace `sys.error` by `IllegalStateException`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36524:
URL: https://github.com/apache/spark/pull/36524#issuecomment-1125083351
@cloud-fan @srielau FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36524: [SPARK-39165][SQL] Replace `sys.error` by `IllegalStateException`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36524:
URL: https://github.com/apache/spark/pull/36524#issuecomment-1125114545
Merging to master. Thank you, @srowen for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org