You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2025/08/28 00:49:18 UTC
[PR] Improve internal debug logging message consistency in configuration file parsing [logging-log4cxx]
swebb2066 opened a new pull request, #527:
URL: https://github.com/apache/logging-log4cxx/pull/527
This PR aims to improve the usefulness of Log4cxx internal debug logging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve internal debug logging message consistency in configuration file parsing [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #527:
URL: https://github.com/apache/logging-log4cxx/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve internal debug logging message consistency in configuration file parsing [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on code in PR #527:
URL: https://github.com/apache/logging-log4cxx/pull/527#discussion_r2305973757
##########
src/main/cpp/domconfigurator.cpp:
##########
@@ -840,13 +846,6 @@ spi::ConfigurationStatus DOMConfigurator::doConfigure
{
m_priv->repository = repository ? repository : LogManager::getLoggerRepository();
m_priv->repository->setConfigured(true);
- if (LogLog::isDebugEnabled())
Review Comment:
do we print this message out(what file is being used for configuration) anyplace else? That can be useful to know when you're unsure which file is being used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve internal debug logging message consistency in configuration file parsing [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on code in PR #527:
URL: https://github.com/apache/logging-log4cxx/pull/527#discussion_r2305980601
##########
src/main/cpp/domconfigurator.cpp:
##########
@@ -840,13 +846,6 @@ spi::ConfigurationStatus DOMConfigurator::doConfigure
{
m_priv->repository = repository ? repository : LogManager::getLoggerRepository();
m_priv->repository->setConfigured(true);
- if (LogLog::isDebugEnabled())
Review Comment:
Yes, a few lines below it outputs either "Loading configuration file [" ... or "Could not read configuration file [" ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org