[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7614: Fix exception when using complex aggs with result level caching

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #7614: Fix exception when using complex aggs with result level caching
URL: https://github.com/apache/incubator-druid/pull/7614#discussion_r282239041
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java
 ##########
 @@ -566,12 +566,24 @@ public Row apply(Object input)
                   DimensionHandlerUtils.convertObjectToType(results.next(), dimensionSpec.getOutputType())
               );
             }
-
             Iterator<AggregatorFactory> aggsIter = aggs.iterator();
+
+            // When using the result level cache, the agg values seen here are
 
 Review comment:
   Extracted to a helper method in `CacheStrategy` (`CacheUtil` is in `server` which is not a dependency of `processing`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org