You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "YuanbenWang (via GitHub)" <gi...@apache.org> on 2023/08/28 12:50:10 UTC
[GitHub] [ozone] YuanbenWang opened a new pull request, #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
YuanbenWang opened a new pull request, #5228:
URL: https://github.com/apache/ozone/pull/5228
## What changes were proposed in this pull request?
This pr aims to let ContainerBalancerConfiguration#toString print more information when called.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9220
## How was this patch tested?
From:
To:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1717037940
Thanks @YuanbenWang for the contribution, @Xushaohong and @dineshchitlangia, @siddhantsangwan for the code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #5228:
URL: https://github.com/apache/ozone/pull/5228#discussion_r1311582157
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -411,15 +411,42 @@ public String toString() {
"%-50s %d%n" +
"%-50s %dGB%n" +
"%-50s %dGB%n" +
- "%-50s %dGB%n", "Key", "Value", "Threshold",
+ "%-50s %dGB%n" +
+ "%-50s %d%n" +
+ "%-50s %dmin%n" +
+ "%-50s %dmin%n" +
+ "%-50s %dmin%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" , "Key", "Value", "Threshold",
threshold, "Max Datanodes to Involve per Iteration(percent)",
maxDatanodesPercentageToInvolvePerIteration,
"Max Size to Move per Iteration",
maxSizeToMovePerIteration / OzoneConsts.GB,
"Max Size Entering Target per Iteration",
maxSizeEnteringTarget / OzoneConsts.GB,
"Max Size Leaving Source per Iteration",
- maxSizeLeavingSource / OzoneConsts.GB);
+ maxSizeLeavingSource / OzoneConsts.GB,
+ "Number of Iterations",
+ iterations,
+ "Time Limit for Single Container's Movement",
+ Duration.ofMillis(moveTimeout).toMinutes(),
+ "Time Limit for Container Replication's Move",
Review Comment:
```suggestion
"Time Limit for Single Container's Replication",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1702896260
> Giving more direct config details. It looks good to me. thx @YuanbenWang
Thanks for the review~!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1703884266
> +1 pending CI
Thanks for the review~! I have fix the checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1709480036
@dineshchitlangia CI got 503 error code, so could you help to retrigger it ? Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #5228:
URL: https://github.com/apache/ozone/pull/5228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on a diff in pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on code in PR #5228:
URL: https://github.com/apache/ozone/pull/5228#discussion_r1312479939
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -411,15 +411,42 @@ public String toString() {
"%-50s %d%n" +
"%-50s %dGB%n" +
"%-50s %dGB%n" +
- "%-50s %dGB%n", "Key", "Value", "Threshold",
+ "%-50s %dGB%n" +
+ "%-50s %d%n" +
+ "%-50s %dmin%n" +
+ "%-50s %dmin%n" +
+ "%-50s %dmin%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" +
+ "%-50s %s%n" , "Key", "Value", "Threshold",
threshold, "Max Datanodes to Involve per Iteration(percent)",
maxDatanodesPercentageToInvolvePerIteration,
"Max Size to Move per Iteration",
maxSizeToMovePerIteration / OzoneConsts.GB,
"Max Size Entering Target per Iteration",
maxSizeEnteringTarget / OzoneConsts.GB,
"Max Size Leaving Source per Iteration",
- maxSizeLeavingSource / OzoneConsts.GB);
+ maxSizeLeavingSource / OzoneConsts.GB,
+ "Number of Iterations",
+ iterations,
+ "Time Limit for Single Container's Movement",
+ Duration.ofMillis(moveTimeout).toMinutes(),
+ "Time Limit for Container Replication's Move",
Review Comment:
Thank you for the review~! I have changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1717155429
@siddhantsangwan @ChenSammi @dineshchitlangia @Xushaohong Thank you for your assistance in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1709481183
In my own CI, all test are success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1709484439
I've triggered a CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] YuanbenWang commented on pull request #5228: HDDS-9220. Let ContainerBalancerConfiguration#toString print more info
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5228:
URL: https://github.com/apache/ozone/pull/5228#issuecomment-1711129739
> I've triggered a CI run.
All the test are success. Would you please help merge this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org