You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/18 03:10:06 UTC

[GitHub] [apisix-dashboard] Si-ege opened a new pull request #2327: chore：1.Create page, add description under name input box 2.Create/Edit/Delete Success prompt to delete spaces 3.List page, add enabled plugin fields

Si-ege opened a new pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#discussion_r810589515



##########
File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js
##########
@@ -30,6 +30,7 @@ context('Create and Delete Consumer', () => {
     monacoScroll: '.monaco-scrollable-element',
     monacoViewZones: '.view-zones',
     notificationCloseIcon: '.ant-notification-close-icon',
+    DetectionofPluginfields: '.ant-tabel-cell',

Review comment:
       It doesn't look like it's being used, please remove it

##########
File path: web/src/pages/Consumer/List.tsx
##########
@@ -64,6 +64,12 @@ const Page: React.FC = () => {
       hideInSearch: true,
       render: (text) => timestampToLocaleString(text as number),
     },
+    {
+      title: formatMessage({ id: 'menu.plugin' }),
+      dataIndex: 'plugins',
+      hideInSearch: true,
+      render: (_, record) => <>{Object.keys(record.plugins).join(',')}</>,

Review comment:
       ```suggestion
         render: (_, record) => Object.keys(record.plugins).join(','),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Si-ege commented on pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
Si-ege commented on pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#issuecomment-1044028705


   已改 请查阅
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人:                                                                                                                        "apache/apisix-dashboard"                                                                                    ***@***.***&gt;;
   发送时间:&nbsp;2022年2月18日(星期五) 中午1:49
   ***@***.***&gt;;
   ***@***.******@***.***&gt;;
   主题:&nbsp;Re: [apache/apisix-dashboard] feat: improve Consumer module (PR #2327)
   
   
   
   
   
    
   @guoqqqi commented on this pull request.
    
    
   In web/src/pages/Consumer/Create.tsx:
    &gt; @@ -64,7 +64,7 @@ const Page: React.FC = (props) =&gt; {              username                ? formatMessage({ id: 'component.global.edit' })                : formatMessage({ id: 'component.global.create' }) -          } ${formatMessage({ id: 'menu.consumer' })} ${formatMessage({ +          }${formatMessage({ id: 'menu.consumer' })}${formatMessage({  
   Please check if this is displayed correctly in English
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you authored the thread.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#discussion_r809693082



##########
File path: web/src/pages/Consumer/Create.tsx
##########
@@ -64,7 +64,7 @@ const Page: React.FC = (props) => {
             username
               ? formatMessage({ id: 'component.global.edit' })
               : formatMessage({ id: 'component.global.create' })
-          } ${formatMessage({ id: 'menu.consumer' })} ${formatMessage({
+          }${formatMessage({ id: 'menu.consumer' })}${formatMessage({

Review comment:
       Please check if this is displayed correctly in English




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Si-ege removed a comment on pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
Si-ege removed a comment on pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#issuecomment-1044028705


   已改 请查阅
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人:                                                                                                                        "apache/apisix-dashboard"                                                                                    ***@***.***&gt;;
   发送时间:&nbsp;2022年2月18日(星期五) 中午1:49
   ***@***.***&gt;;
   ***@***.******@***.***&gt;;
   主题:&nbsp;Re: [apache/apisix-dashboard] feat: improve Consumer module (PR #2327)
   
   
   
   
   
    
   @guoqqqi commented on this pull request.
    
    
   In web/src/pages/Consumer/Create.tsx:
    &gt; @@ -64,7 +64,7 @@ const Page: React.FC = (props) =&gt; {              username                ? formatMessage({ id: 'component.global.edit' })                : formatMessage({ id: 'component.global.create' }) -          } ${formatMessage({ id: 'menu.consumer' })} ${formatMessage({ +          }${formatMessage({ id: 'menu.consumer' })}${formatMessage({  
   Please check if this is displayed correctly in English
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you authored the thread.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#issuecomment-1053554759


   also cc @bzp2010 Please help trigger CI ～


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#issuecomment-1044214714


   Front-end test cases need to be updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2327: feat: improve Consumer module

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2327:
URL: https://github.com/apache/apisix-dashboard/pull/2327#issuecomment-1053563015


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2327](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0474388) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1f5f8b0c3747a8bc4374c5d06dd14e8c5f77afb6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f5f8b0) will **increase** coverage by `0.01%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2327/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2327      +/-   ##
   ==========================================
   + Coverage   68.16%   68.18%   +0.01%     
   ==========================================
     Files         127      127              
     Lines        3374     3376       +2     
     Branches      830      830              
   ==========================================
   + Hits         2300     2302       +2     
     Misses       1074     1074              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.18% <66.66%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `82.94% <ø> (+0.10%)` | :arrow_up: |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <50.00%> (ø)` | |
   | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2327/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `87.80% <100.00%> (+0.30%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f5f8b0...0474388](https://codecov.io/gh/apache/apisix-dashboard/pull/2327?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org